Simplify code and classes used to style toast elements - #3847
Open
rdwebdesign wants to merge 3 commits into
Open
Simplify code and classes used to style toast elements#3847rdwebdesign wants to merge 3 commits into
rdwebdesign wants to merge 3 commits into
Conversation
- use AdminLTE v4 classes to style toasts. - simplify the javascript code a little, reducing the number of added CSS classes. - remove redundant classes: align-items-center, shadow and rounded (styles already applied by the `.toast` class) - use `toast-danger` when the toast type is "error" Signed-off-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
replace/notify_adjust_classes
branch
from
August 9, 2026 03:44
8847d2f to
841e0da
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
This branch simplifies a little the CSS classes used to style toasts.
It is an extension of
replace/notifybranch.How does this PR accomplish the above?
The original code was adding bootstrap 5 classes to 3 different elements of the toast markup. This PR adds just one AdminLTE class to the main toast element.
We also removed a few redundant classes (styles already present on the AdminLTE theme).
By submitting this pull request, I confirm the following:
git rebase)