Use the default AdminLTEv4 sidebar behavior - #3850
Conversation
Use the "slide" effect instead of using the "sidebar-mini". We also add `overflow: hidden` to the app-wrapper when using boxed layout, to make sure the sidebar is completetly hidden on screens wider than the boxed layout. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
yubiuser
left a comment
There was a problem hiding this comment.
The new slide effect moves the whole sidebar in its entire length, including the upper part. On mobile, this "covers" the arrows which is a bit strange as they seem to just disappear.
Additionally, on collapsing there is some kind of overlay of the word "Pi-hole" in the upper corner. It seems to double interleaved with two font sizes and one being bold, something like "Pi-Pi-holehole"
Since the sidebar is now 100% hidden when collapsed, we don't need that CSS hack anymore. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
This is how the new sidebar was created. Please check the official AdminLTE examples: The arrow is not really needed. Clicking anywhere outside the sidebar will close it. EDIT: .sidebar-open .navbar-expand .navbar-nav {
margin-left: var(--lte-sidebar-width);
}This is hack. The button won't be really clickable (it will be behind the overlay element). The sidebar will actually close when the overlay area is clicked, but visually it will seem like the button was clicked.
Good catch. Fixed by the most recent commit. |
yubiuser
left a comment
There was a problem hiding this comment.
No need to start with hacks again. Let's try to stay close to the default behavior.
What does this PR aim to accomplish?
Use the default "slide" effect for the side bar.
The default behavior can be seen here (full screen):
https://adminlte.io/themes/v4/layout/unfixed-sidebar.html
And the same behavior applied to our custom "boxed layout":

Internal discussion:
https://team.pi-hole.net/pi-hole/pl/61nadgr6rig8in9hw94pebygzo
How does this PR accomplish the above?
Removing the
.sidebar-miniclass from the body.By submitting this pull request, I confirm the following:
git rebase)