Km-15482: Fix out-of-order status change#35
Merged
Merged
Conversation
1196927 to
4e99a15
Compare
kp-juan-docal
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a connect attempt failed (e.g. SSL hostname mismatch), the
inner Start{Wireguard,OpenVpn}ConnectionController.handleFailure emitted
Disconnected before the outer StartConnectionController's cleanup path
emitted its own Disconnecting → Disconnected, producing an out-of-order
sequence visible to clients:
Changes:
clear cache and rethrow so the outer cleanup path owns the terminal
status sequence.
even when the cleanup chain fails partway (e.g. when stop is invoked
from the Start failure path before native resources were created), so
clients always observe a terminal state.
Result: handleConnectionStatusChange(...) sees the canonical
Connecting → Disconnecting → Disconnected(reason) on failure.