Skip to content

Conversation

sinisaos
Copy link
Member

Related to #1264

Comment on lines -64 to +65
with pytest.warns(None) as recorded_warnings:
with warnings.catch_warnings() as recorded_warnings:
warnings.simplefilter("error")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made because Python 3.14 does not allow the type None in pytest.warns() (TypeError: exceptions must be derived from Warning, not <class 'NoneType'>)


def test_reflect_all_tables(self):
run_sync(self.table_storage.reflect())
run_sync(self.table_storage.reflect(exclude=["migration"]))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason in Python 3.14 (which I don't understand) the migration table is included in the table storage and the tests fail. I exclude the migration table from table storage to prevent this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, interesting. I'll try it locally. I wonder what changed in Python 3.14 to cause this.

@dantownsend
Copy link
Member

I've made a fresh virtual env using Python 3.14, but can't install some of our pip dependencies. Will try again tomorrow.

@sinisaos
Copy link
Member Author

@dantownsend Strange. Now I'm cloned the branch in fresh virtualenv and everything works in my case. Which OS do you use? I use Linux Mint 22.2 Cinnamon which is based on Ubuntu 24.04 LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants