fix: ChannelController.debugAssertNotDisposed()
throwing when calli…
#2558
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when disposing
PlatformInAppWebViewController
, it callsInternalChannelController.disposeChannel()
which tries to set the channel handler to null, but the issue is that it access the channel through the getterchannel
which has a debug assert that it shouldn't be disposed (channel == null
)this might or might not cause the resources to not be freed while debugging
in this pr, we access the
_channel
variable directly, if it's null thensetMethodCallHandler
will simply not executeConnection with issue(s)
Resolve issue #2104
Connected to N/A
Testing and Review Notes
to test
Screenshots or Videos
To Do