Skip to content

Conversation

@karyotakisg
Copy link

@karyotakisg karyotakisg commented Jul 16, 2025

Breaking change

Proposed change

As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.

Specifically, the dependencies certifi and keyrings.alt are specified as a requirement in the requirements.txt file, when in reality they are not needed.

certifi, introduced in 9539a2c is a transitive dependency of requests.
This PR removes it from requirements.txt to let pip manage it automatically, which helps keeping the dependency list clean.

keyrings.alt, introduced in 9dcbd46 is not used in the project.

Hope this is helpful!

Best regards

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant