Fix OP_GETGV symbol encoding for $&, $\, $', $1..$9` #10
Open
hadashiA wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codegen_prism.incmis-encodes two kinds of global-variable reads inOP_GETGVoperands:Back-references (
$&,$`,$',$+) all useMRC_SYM_2(back_ref), the presym bound to the literal"$+", soevery back-reference collapses to
"$+"in the dumped bytecode.Numbered references (
$1..$9) build the name in a local stackbuffer and hand the pointer to
pm_constant_pool_insert_constant,which stores the pointer without copying. After the codegen
function returns the buffer is reused, so the dumped symbol bytes
are garbage (we observed
\x08Gfor$1).Reproduce
Fix
cast->name(the Prism constant_id for the actualtoken bytes — already in the pool).
mrc_malloca heap copy and hand ownership to thepool via
pm_constant_pool_insert_owned.