Merged
Conversation
Owner
pictos
commented
Nov 18, 2025
added 3 commits
November 17, 2025 23:28
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project from .NET 9.0 to .NET 10.0, including framework targets, package versions, and CI/CD configurations.
Key Changes:
- Updates .NET target frameworks from net9.0 to net10.0 across project files
- Updates MAUI version from 9.0.70 to 10.0.10
- Updates CI/CD workflows to use .NET 10.0.x, macOS 26, and Xcode 26.1
- Adds TODO comment about animation method alternatives
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Updates NetVersion to net10.0 and MauiVersion to 10.0.10 |
| PJ.NavigationTrans.Sample/PJ.NavigationTrans.Sample.csproj | Updates target frameworks to net10.0-android/ios and Microsoft.Extensions.Logging.Debug to version 10.0.0 |
| .github/workflows/dotnet-windows.yml | Updates .NET SDK version to 10.0.x |
| .github/workflows/dotnet-macos.yml | Updates .NET SDK to 10.0.x, macOS runner to macos-26, and Xcode to 26.1 |
| PJ.NavigationTrans.Maui/Platforms/Android/NavigationPage/NavigationViewFragmentTrans.cs | Adds TODO comment about OnCreateAnimator method |
Comments suppressed due to low confidence (2)
.github/workflows/dotnet-macos.yml:43
- The build target framework 'net9.0-ios' is inconsistent with the updated project files that now target net10.0. This should be updated to 'net10.0-ios' to match the project's TargetFrameworks.
run: dotnet build ${{env.LIB_CSPROJ}} -c Release -f net9.0-ios --no-restore
.github/workflows/dotnet-macos.yml:46
- The build target framework 'net9.0-ios' is inconsistent with the updated project files that now target net10.0. This should be updated to 'net10.0-ios' to match the project's TargetFrameworks.
run: dotnet build ${{env.SAMPLE_CSPROJ}} -c Release -f net9.0-ios --no-restore
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
