feat: Improve Secret inspection privacy and usage messaging#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
kubectl-peek secretworkflow by making Secret inspection safer and more explicit.By default, the command now shows Secret values without performing usage discovery. Relationship discovery is only executed when explicitly requested.
Changes
Usage discovery is now opt-in
kubectl-peek secretno longer searches for or displays related resources by default.Use:
to discover and display resources that use, produce, or reference the selected Secret.
This also avoids unnecessary API calls and permission warnings when relationship discovery is not needed.
Secret values can be redacted
Secret values remain visible by default for backward compatibility.
Use:
to hide decoded values.
Redacted values keep the key name and display the original byte length:
Both options can be combined:
Clearer message when no relationships are found
When usage discovery is enabled but no supported references are detected, the output now explains that the result is not a guarantee that the Secret is unused.
Example:
Resulting behavior
Used bysection.