Skip to content

Conversation

@SoylentGraham
Copy link

I'm currently building the source directly to a framework/package in xcode (skipping Cmake), and the default setup enables ARC (Automatic ref counting in objective-c)

This is a simple fix (don't manually release!) but hard/impossible to put into a macro, so spun the bulk of the kernel-loading macro into a lambda.

@pierotofy
Copy link
Owner

pierotofy commented Jun 30, 2025

../input_data.cpp:75:28: error: ‘getOptimalNewCameraMatrix’ is not a member of ‘cv’
   75 |         cv::Mat newK = cv::getOptimalNewCameraMatrix(cK, distCoeffs, cv::Size(cImg.cols, cImg.rows), 0, cv::Size(), &roi);

I don't think you should remove #include <opencv2/calib3d.hpp>

I'm also not sure I understand the fix here. If you're skipping cmake, can't you just adjust your compiler settings?

@SoylentGraham
Copy link
Author

I don't think you should remove #include <opencv2/calib3d.hpp>

I'm also not sure I understand the fix here. If you're skipping cmake, can't you just adjust your compiler settings?

Yeah this was supposed to be in a different branch, I rebuilt skipping opencv. Building with CMake then broke (although as an aside, I think this include can just be in the cpp)

Will do another PR later with some other changes to the loading here (ie, don't try and load from the source-code-path and/or let the user supply shader)

@SoylentGraham
Copy link
Author

I'm also not sure I understand the fix here. If you're skipping cmake, can't you just adjust your compiler settings?

I require ARC to be on because of other things, if I turn it off, other things break :)

It's easy to handle compiling with and without ARC (and really, it should be on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants