Skip to content

Conversation

@fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Jul 18, 2025

  • Converts grid factors and storage factors to expert guesses.
  • Grid factor data does not change.
  • Differences in f32_factorStorage.cs4r
       V1  year  V2        x        y     diff    factor
NEU   NEU dummy spv 1.000000 1.899273 0.899273 1.8992730
NEU.1 NEU dummy csp 1.000000 1.872558 0.872558 1.8725580
EUR.1 EUR dummy csp 1.000000 1.589584 0.589584 1.5895840
REF   REF dummy spv 1.049840 1.400000 0.350160 1.3335365
REF.1 REF dummy csp 0.787597 1.000000 0.212403 1.2696849
OAS   OAS dummy csp 1.000000 0.800000 0.200000 0.8000000
EUR   EUR dummy spv 1.748404 1.589584 0.158820 0.9091629
IND   IND dummy spv 0.900000 0.800000 0.100000 0.8888889
SSA.1 SSA dummy csp 0.663000 0.600000 0.063000 0.9049774
MEA   MEA dummy spv 0.775613 0.750000 0.025613 0.9669771
SSA   SSA dummy spv 0.873625 0.850000 0.023625 0.9729575
CHA   CHA dummy spv 1.399230 1.400000 0.000770 1.0005503
LAM   LAM dummy csp 0.999943 1.000000 0.000057 1.0000570

This solves
https://github.com/remindmodel/development_issues/issues/605 and
https://github.com/remindmodel/development_issues/issues/607

@fbenke-pik fbenke-pik marked this pull request as ready for review July 24, 2025 09:00
@robertpietzcker
Copy link
Contributor

@fbenke-pik is x or y the new one?

@fbenke-pik
Copy link
Contributor Author

@fbenke-pik is x or y the new one?

x is old. y is new.

@robertpietzcker
Copy link
Contributor

I don't get why NEU now has 1.8 for spv.

we use 2.3 for NEN (non-EU north) and 0.8 for NES (non-EU south). The weight should be PV production, and my guess would be that the production in Turkey (NES) is much higher than in NEN, so I would expect the NEU value to be much closer to 0.8 than 2.3

could you check the weights that are used in aggregation?

@fbenke-pik
Copy link
Contributor Author

The weight is calculated here https://github.com/pik-piam/mrremind/blob/master/R/calcStorageFactor.R#L18-L22

> weightSolar[c("ALB","AND", "BIH", "CHE", "GRL", "ISL", "LIE", "MCO", "MKD", "MNE", "NOR", "SJM", "SMR", "SRB", "TUR", "VAT"),,]
An object of class "magpie"
, ,  = spv

      Year
region  y2010
   ALB   2095
   AND     38
   BIH   3084
   CHE   5941
   GRL      0
   ISL  12957
   LIE     10
   MCO      0
   MKD   1441
   MNE   1186
   NOR 132127
   SJM      0
   SMR      6
   SRB   1245
   TUR  45963
   VAT      0
``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants