-
Notifications
You must be signed in to change notification settings - Fork 52
convert storageFactor to Expert Guess #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@fbenke-pik is x or y the new one? |
x is old. y is new. |
|
I don't get why NEU now has 1.8 for spv. we use 2.3 for NEN (non-EU north) and 0.8 for NES (non-EU south). The weight should be PV production, and my guess would be that the production in Turkey (NES) is much higher than in NEN, so I would expect the NEU value to be much closer to 0.8 than 2.3 could you check the weights that are used in aggregation? |
|
The weight is calculated here https://github.com/pik-piam/mrremind/blob/master/R/calcStorageFactor.R#L18-L22 |
f32_factorStorage.cs4rThis solves
https://github.com/remindmodel/development_issues/issues/605 and
https://github.com/remindmodel/development_issues/issues/607