Bugfix tansport energy service reporting #651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @LaviniaBaumstark, kannst du da vielleicht auch etwas zu sagen? Felix ist ja grade im Urlaub.. |
LaviniaBaumstark
approved these changes
Sep 2, 2024
fschreyer
requested changes
Sep 2, 2024
Contributor
fschreyer
left a comment
fschreyer
left a comment
There was a problem hiding this comment.
I do not see what is wrong in the old reporting as vm_cesIO is multiplied by TWa_2_EJ at the top of reportFE. It needs to be divided here to get back to tr pkm/yr, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport energy service demand is multiplied by a factor 1/TWaToEJ = ~0.03, but is given in trillion (p|t)km in vm_cesIO.
In this PR the factor is removed