-
Notifications
You must be signed in to change notification settings - Fork 50
reportEmi: more summations and consistency #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Did you test that you did not introduce any summation errors? You should run remind2::convGDX2MIF on some representative gdxes and make sure the output yields "All Summation Checks were fine" |
fschreyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no summation errors are introduced, I am fine with it.
| setNames( | ||
| out[, , "Emi|CO2|Gross|Energy and Industrial Processes (Mt CO2/yr)"] | ||
| - out[, , "Emi|CO2|Gross|+|Energy (Mt CO2/yr)"], | ||
| "Emi|CO2|Gross|+|Industrial Processes (Mt CO2/yr)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't gross emissions = net emissions for industrial processes? We only have cement calcination emissions here which are purely fossil and chemical feedstock processing emissions which cannot be captured. I don't see how there can be negative emissions.
Although maybe in the future...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that emi|gross|ip = emi|ip, although I'm not sure because there is also a variable "Emi|CO2|Industrial Processes|CDR Sector|+|OAE (Mt CO2/yr)".
In any case, I find it clearer if there is an intuitive summation of Emi|CO2|Gross components rather than having to guess that emi|ip is probably gross already (this type of guess is not obvious as a non-emission expert). What do you think?
| + out[, , "Emi|CO2|CDR|+|Synthetic Fuels CCS (Mt CO2/yr)"] | ||
| + out[, , "Emi|CO2|CDR|+|Materials (Mt CO2/yr)"], | ||
| "Emi|CO2|CDR (Mt CO2/yr)" | ||
| "Emi|CO2|+++|CDR (Mt CO2/yr)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And Emi|CO2|+++|Gross + Emi|CO2|+++|CDR actually always sum up to Emi|CO2? I vaguely remember there was at some point a reason why we didn't put the summation pluses here.
Generally, ofc good to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, didnt think of that. Could it have been that plastics used to create a delay between when they account for CDR and when they are burnt and emit?
I'll check how bad the summation is currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction: this code snippet should ensure the summation?
# total gross emissions (CDR and Gross should add up to net emissions)
setNames(
out[, , "Emi|CO2 (Mt CO2/yr)"]
- out[, , "Emi|CO2|+++|CDR (Mt CO2/yr)"],
"Emi|CO2|+++|Gross (Mt CO2/yr)"
)| showLinePlots(data, "Res|Extraction|Uranium [Energy]") | ||
| showLinePlots(data, "Res|Extraction|Uranium") | ||
| ``` | ||
| Note: multiply EJ by 7.16 to obtain kt of Uranium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that an unfixed bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two line plots were exactly similar except for the y-scale.
I thought it made more sense to keep only one chart, and indicate the scaling factor.
Purpose of this PR
Add the following reporting for Gross and Cumulated CO2 emissions (and use it for more detailed cs2 charts):
Add the following summations:
Checklist:
I checked the tests when running buildLibrary and made sure that my changes