Allow maxAge of 0#97
Open
smcmurray wants to merge 3 commits intopillarjs:masterfrom
smcmurray:patch-2
Open
Conversation
Contributor
|
Thanks @smcmurray ! Weird, though, because when I cherry-pick your test onto master without your changes, it passes. I can commit just your test if this is the case, as it looks like there isn't a bug here based on your test 👍 |
Author
|
Perhaps my assert is bad. I don't know what assert lib this uses or how it handles comparisons with 0. |
Contributor
|
We use the one that is part of Node.js: https://nodejs.org/dist/latest-v10.x/docs/api/assert.html |
dougwilson
suggested changes
May 20, 2018
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Marking as needs test update, as it seems like the consensus is the test is bad currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.