Conversation
|
@dougwilson ping |
.travis.yml
Outdated
| # Setup Node.js version-specific dependencies | ||
| - "test $TRAVIS_NODE_VERSION != '0.8' || npm rm --save-dev istanbul" | ||
| - "test $(echo $TRAVIS_NODE_VERSION | cut -d. -f1) -ge 4 || npm rm --save-dev eslint" | ||
| - "test -z $(echo $HTTP2_TEST) || npm install --only=dev https://github.com/sogaani/express.git#initial-support-http2 https://github.com/sogaani/supertest.git#http2" |
There was a problem hiding this comment.
Please only install deps from npm.
There was a problem hiding this comment.
Express and this PR has circular dependency. Would you allow me to add http2 enabled express package like express-http2 for npm?
There was a problem hiding this comment.
Express.js does not have a dependency on this module. Not sure what you mean there is a circular dependency.
There was a problem hiding this comment.
Express use cookie-session for test, and cookie-session depend on cokkies.
There was a problem hiding this comment.
And the tests in this module won't work with the published version of Express?
There was a problem hiding this comment.
Yes.
No.
I met following errors with the published version of Express.
1) Express should set cookies:
Uncaught TypeError: Cannot read property 'readable' of undefined
at IncomingMessage._read (_http_incoming.js:104:19)
at IncomingMessage.Readable.read (_stream_readable.js:442:10)
at IncomingMessage.read (_http_incoming.js:96:15)
at resume_ (_stream_readable.js:822:12)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
|
I fixed PR installing deps only from npm. |
2 participants
Support http2 to enable express tests with http2.
expressjs/express#3390.