Skip to content

ci: create github actions CI pipeline and remove travis pipeline #20

Merged
blakeembrey merged 2 commits intopillarjs:masterfrom
Phillip9587:ci
Aug 18, 2025
Merged

ci: create github actions CI pipeline and remove travis pipeline #20
blakeembrey merged 2 commits intopillarjs:masterfrom
Phillip9587:ci

Conversation

@Phillip9587
Copy link
Copy Markdown
Contributor

closes #11

@Phillip9587 Phillip9587 requested a review from UlisesGascon June 20, 2025 16:17
@Phillip9587 Phillip9587 added the github_actions Pull requests that update GitHub Actions code label Jun 20, 2025
@UlisesGascon UlisesGascon self-assigned this Jun 21, 2025
Copy link
Copy Markdown
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon requested a review from blakeembrey June 21, 2025 06:13
@UlisesGascon UlisesGascon removed their assignment Jun 21, 2025
@Phillip9587
Copy link
Copy Markdown
Contributor Author

Hey @UlisesGascon @blakeembrey can we land this PR?

@UlisesGascon
Copy link
Copy Markdown
Member

I plan to land this PR next week, unless is advised other wise 👍

"istanbul": "0.4.5",
"mocha": "2.5.3"
"mocha": "~11.7.0",
"nyc": "~17.1.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary for GitHub Actions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.npmjs.com/package/istanbul is deprecated. nyc is the successor to istanbul according to their website: https://istanbul.js.org/integrations/

@Phillip9587
Copy link
Copy Markdown
Contributor Author

@blakeembrey I updated the PR with your suggestions and added a commit replacing the deprecated ::set-output command with the $GITHUB_OUTPUT environment file: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@Phillip9587
Copy link
Copy Markdown
Contributor Author

CI failure is unrelated:

📄 Using coverage file: ./lcov.info
🚀 Posting coverage data to https://coveralls.io/api/v1/jobs
HTTP error:
---
Error: Service Unavailable (503)
Message: <h2>This website is under heavy load (queue full)</h2><p>We're sorry, too many people are accessing this website at the same time. We're working on this problem. Please try again later.</p>
---

@blakeembrey
Copy link
Copy Markdown
Member

CI failure is unrelated

SG, I saw it passed before. We can always look at migrating it over to codecov if it continues to be an issue.

@blakeembrey blakeembrey merged commit cd9d9bf into pillarjs:master Aug 18, 2025
30 of 31 checks passed
@Phillip9587 Phillip9587 deleted the ci branch August 18, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time to migrate to GH actions

4 participants