chore(ci/cd): add newer node versions to test matrix #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
reviewed
Jan 6, 2026
Apply changes from code review Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
Contributor
Author
|
@bjohansebas sorry our conversation was marked as resolved when I committed your changes but as for adding a non LTS version of Node to the matrix, I think we can add the current release (v25) would that be enough in your opinion? I think since we're adding tests for v22 and v24 there's no need to add one for v23? but I don't know, let me know what you think! |
Member
|
Well, it’s been our practice to have CI for all the versions we support, including non-LTS ones. In my opinion, it would be good to test all the supported LTS versions, to keep consistency with the other repositories |
Contributor
Author
|
I've added non-LTS and the current Node release versions, lmkwyt! |
jonchurch
approved these changes
Jan 7, 2026
UlisesGascon
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds newer versions of Node to the test matrix to ensure compatibility ahead of the
5.0release.