Skip to content

Feature/process element exception event - #500

Merged
mcop1 merged 5 commits into
pimcore:2.xfrom
TorqIT:feature/process-element-exception-event
Aug 19, 2025
Merged

Feature/process element exception event#500
mcop1 merged 5 commits into
pimcore:2.xfrom
TorqIT:feature/process-element-exception-event

Conversation

@torqdev

@torqdev torqdev commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Resolves #346

  • Added doc about event
  • Added new event which is fired when an exception is caught inside the processElement function of ImportProcessingService

@IronSean

Copy link
Copy Markdown

Love this, opens up a lot of possibilities without making major changes to the existing logic. I could see this allowing an implementation to add:

  • Better error logging where you don't just see the row and the error, but but field was being processed and the actual exception stack trace.
  • Logic to allow automate retrying of known transient errors.
  • Logic to allow error rows to be saved in a separate queue or custom table for manual review outside of the application logger (with the extra information about which field caused the error)
  • User notifications for failed rows on specific imports
  • etc.

@mcop1 mcop1 self-assigned this Aug 12, 2025
@mcop1

mcop1 commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Hello @torqdev ,
I tried to fix the codeception tests, could you please update the pr branch with the latest changes from 2.x?

@sonarqubecloud

Copy link
Copy Markdown

@torqdev

torqdev commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

Hello @torqdev , I tried to fix the codeception tests, could you please update the pr branch with the latest changes from 2.x?

@mcop1 - Done

@mcop1 mcop1 added this to the 2.2.0 milestone Aug 19, 2025
@mcop1

mcop1 commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Thank you!

@mcop1
mcop1 merged commit 6d04a49 into pimcore:2.x Aug 19, 2025
13 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 19, 2025
@lukemacausland
lukemacausland deleted the feature/process-element-exception-event branch August 20, 2025 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: PostSaveFailEvent upon failing to import a queued item

6 participants