Skip to content

Refactor VideoSerializationHandler for asset properties #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpfaffenbauer wants to merge 5 commits into
base: 2026.x
Choose a base branch
from
Open

Refactor VideoSerializationHandler for asset properties #481

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
084eb29
Refactor VideoSerializationHandler for asset properties
dpfaffenbauer Jul 23, 2026
001d051
Fix error logging in VideoSerializationHandler
dpfaffenbauer Jul 23, 2026
674779f
Update VideoSerializationHandler.php
dpfaffenbauer Jul 23, 2026
d7cc3f8
Merge branch '2026.x' into patch-1
dpfaffenbauer Jul 29, 2026
96768f4
Fix duplicate method definitions and missing Exception import
dpfaffenbauer Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ class VideoSerializationHandler extends AbstractHandler
{
use LoggerAwareTrait;

private const ERROR_SEPARATOR = ' error ';

public function getAdditionalSystemFields(Asset $asset): array
{
if (!$asset instanceof Video) {
Expand Down Expand Up @@ -56,7 +58,7 @@ private function getImageThumbnail(Video $video): ?string
} catch (Throwable $e) {
$this->logger->error('Thumbnail generation failed for video asset: ' .
$video->getId() .
' error ' .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}
Expand All @@ -71,7 +73,7 @@ private function getDuration(Video $video): ?float
} catch (Throwable $e) {
$this->logger->error('Duration extraction failed for video asset: ' .
$video->getId() .
' error ' .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}
Expand All @@ -86,7 +88,7 @@ private function getWidth(Video $video): ?int
} catch (Throwable $e) {
$this->logger->error('Width extraction failed for video asset: ' .
$video->getId() .
' error ' .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}
Expand All @@ -101,7 +103,7 @@ private function getHeight(Video $video): ?int
} catch (Throwable $e) {
$this->logger->error('Height extraction failed for video asset: ' .
$video->getId() .
' error ' .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}
Expand Down
Loading