[Elasticsearch] Require Elasticsearch >= 8.12.2 and test against it - #501
Merged
Conversation
- composer: raise pimcore/elasticsearch-client to ^2026.3 (which requires the elasticsearch/elasticsearch client library ^8.12) - CI: run the Elasticsearch Codeception tests against server 8.12.2 - local test env: bump elasticsearch image to 8.12.2 and repair tests/bin/init-functional-tests.sh (the referenced setup script was renamed to setup-pimcore-environment.sh) - docs: state the new minimum server version See pimcore/internal-improvements#25 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes.
Raises Elasticsearch support to 8.12.2 across dependencies, CI, local testing, and documentation.
Changes:
- Requires
pimcore/elasticsearch-client ^2026.3. - Tests against Elasticsearch 8.12.2.
- Updates setup scripts and compatibility documentation.
Review Contract
- Claimed: Require and test Elasticsearch 8.12.2.
- Root cause: Version updates address the requirement, but local setup introduces a startup race.
- Call sites: Repository references were updated; the companion package’s branch alias remains incompatible.
- Boundary: Changes are in the appropriate dependency, test, and documentation layers.
- Backward compatibility: The intentional minimum-version increase is documented.
- Regression test: CI covers Elasticsearch 8.12.2; local auto-detection remains unreliable.
- Docs/changelog: Updated consistently.
- Remaining risks: Composer cannot currently resolve
^2026.3, and local tests may configure OpenSearch accidentally.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
composer.json |
Raises the Elasticsearch client dependency. |
.github/workflows/elastic-search-codeception.yaml |
Tests with Elasticsearch 8.12.2. |
tests/bin/docker-compose.yaml |
Updates the local Elasticsearch image. |
tests/bin/init-functional-tests.sh |
Switches to auto-detecting the search backend. |
doc/01_Installation/README.md |
Documents supported server versions. |
doc/01_Installation/02_Upgrade.md |
Adds the upgrade notice and fixes wording. |
doc/02_Configuration/05_Elasticsearch.md |
Updates requirements and the client documentation link. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
composer.json: raisepimcore/elasticsearch-clientfrom^2026.1to^2026.3, which requires theelasticsearch/elasticsearchclient library^8.12([Elasticsearch] Raise minimum supported version to 8.12.2 elasticsearch-client#46). Until2026.3.0of the client is tagged, the constraint resolves to2026.x-devin CI (minimum-stability: dev), so CI stays green.8.12.2(was8.5.3).elasticsearchimage to8.12.2and repairtests/bin/init-functional-tests.sh— it still called the removedsetup-pimcore-environment-functional-tests.sh; the currentsetup-pimcore-environment.shauto-detects Elasticsearch, so the script now stops the ES container when testing OpenSearch.8.12.2; fixed the deadblob/1.xlink to the client README.Why
Chunking / nested vector support requires Elasticsearch server
>= 8.12.2.Ref: https://github.com/pimcore/internal-improvements/issues/25 (part of pimcore/product-management#1322)
OpenSearch support is unchanged.
Merge order
pimcore/elasticsearch-client#46 should be merged first.
🤖 Generated with Claude Code