Revert "[Studio UI] Fix full-height tabs and compact tab spacing" (#3884) - #3914
Merged
Conversation
…)" This reverts commit 827edf8.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts #3884 and #3903, restoring the previous tab behavior and rolling back bundled grid, workflow, relation, documentation, translation, and CI changes.
Changes:
- Restores previous tab, modal, pipeline, and grid styling.
- Reverts workflow and relation-field APIs.
- Restores earlier documentation, translations, and workflows.
Reviewed changes
Copilot reviewed 46 out of 51 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
translations/studio.en.yaml |
Restores earlier UI translations. |
CONTRIBUTING.md |
Restores the shorter contribution guide. |
assets/js/src/sdk/modules/element/index.ts |
Removes workflow SDK exports. |
assets/js/src/core/modules/element/listing/decorators/utils/column-configuration/view-layer/components/fields-to-add-panel/fields-to-add-panel.tsx |
Reverts panel header controls. |
assets/js/src/core/modules/element/listing/decorators/utils/column-configuration/view-layer/components/fields-to-add-panel/fields-to-add-panel.styles.ts |
Restores panel spacing. |
assets/js/src/core/modules/element/listing/decorators/utils/column-configuration/view-layer/components/add-column-controls/add-column-controls.tsx |
Restores compact control spacing. |
assets/js/src/core/modules/element/editor/shared-components/workflow/types/workflow-types.ts |
Removes workflow subject type. |
assets/js/src/core/modules/element/editor/shared-components/workflow/provider/workflow-provider.tsx |
Restores editor-bound provider. |
assets/js/src/core/modules/element/editor/shared-components/workflow/provider/editor-workflow-subject-bridge.tsx |
Removes the subject bridge. |
assets/js/src/core/modules/element/editor/shared-components/workflow/modal/workflow-modal.tsx |
Restores the original workflow hook. |
assets/js/src/core/modules/element/editor/shared-components/workflow/hooks/use-workflow-modal-state.ts |
Removes the modal-state hook. |
assets/js/src/core/modules/element/editor/shared-components/workflow/hooks/use-workflow-action.ts |
Restores editor-bound action state. |
assets/js/src/core/modules/element/editor/shared-components/workflow/hooks/use-submit-workflow.ts |
Restores context-based submission. |
assets/js/src/core/modules/element/dynamic-types/definitions/pipelines/grid/source-fields/components/relation-field/relation-field.tsx |
Reverts relation-select styling. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/types/dynamic-type-object-data-reverse-object-relation.tsx |
Removes version-specific rendering. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/types/dynamic-type-object-data-many-to-one-relation.tsx |
Removes version-specific rendering. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/types/dynamic-type-object-data-many-to-many-relation.tsx |
Removes version-specific rendering. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/types/dynamic-type-object-data-many-to-many-object-relation.tsx |
Removes version-specific rendering. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/types/dynamic-type-object-data-advanced-many-to-many-relation.tsx |
Removes version-specific rendering. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/types/dynamic-type-object-data-advanced-many-to-many-object-relation.tsx |
Removes version-specific rendering. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/components/reverse-object-relation/reverse-object-relation.tsx |
Removes open-button suppression. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/components/many-to-many-object-relation/many-to-many-object-relation.tsx |
Removes open-button suppression. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/components/advanced-many-to-many-relation/advanced-many-to-many-relation.tsx |
Removes open-button suppression. |
assets/js/src/core/modules/element/dynamic-types/definitions/objects/data-related/components/advanced-many-to-many-object-relation/advanced-many-to-many-object-relation.tsx |
Removes open-button suppression. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/grid-config-modal.tsx |
Restores the earlier grid modal. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/grid-config-modal.styles.ts |
Removes list padding. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/grid-config-list.tsx |
Restores shared append scrolling. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/forms/advanced-column-form/preview/preview.tsx |
Restores earlier preview layout. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/forms/advanced-column-form/preview/preview.styles.ts |
Removes preview styles. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/forms/advanced-column-form/preview/preview-loader.tsx |
Restores earlier preview messages. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/forms/advanced-column-form/preview/preview-loader.styles.ts |
Removes loader styles. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/forms/advanced-column-form/preview/preview-item-selection.tsx |
Restores basic item selection. |
assets/js/src/core/modules/data-object/listing/decorator/column-configuration/view-layer/components/grid/hooks/use-grid-options/tabs/grid-config/forms/advanced-column-form/advanced-column-form.tsx |
Restores prior pipeline layout. |
assets/js/src/core/modules/asset/listing/decorator/column-configuration/view-layer/components/sidebar/tabs/grid-config/grid-config-list.tsx |
Restores shared append scrolling. |
assets/js/src/core/components/tabs/tabs.styles.tsx |
Removes scoped full-height and spacing rules. |
assets/js/src/core/components/stack-list/stack-list-item.tsx |
Restores collapse styling behavior. |
assets/js/src/core/components/stack-list/stack-list-item.styles.tsx |
Restores earlier borders and padding. |
assets/js/src/core/components/split-layout/components/divider/divider.styles.ts |
Restores divider dimensions. |
assets/js/src/core/components/pipeline/pipeline.tsx |
Removes optional divider suppression. |
assets/js/src/core/components/pipeline/item/dynamic-group/dynamic-group-item.styles.ts |
Restores default form spacing. |
assets/js/src/core/components/pipeline/item/dynamic-group/dynamic-group-content.tsx |
Restores prior content padding. |
assets/js/src/core/components/modal/modal.styles.tsx |
Restores modal title spacing. |
assets/js/src/core/components/many-to-many-relation/many-to-many-relation.tsx |
Removes open-button suppression support. |
assets/js/src/core/components/many-to-many-relation/hooks/use-columns.tsx |
Restores the actions column behavior. |
assets/js/src/core/components/many-to-many-relation/grid.tsx |
Removes the suppression prop. |
.github/workflows/new-static-analysis.yaml |
Restores centralized static analysis. |
.github/workflows/new-poeditor-export.yaml |
Restores POEditor export automation. |
.github/workflows/new-php-cs-fixer.yaml |
Restores PHP-CS-Fixer automation. |
.github/workflows/new-docs.yml |
Restores documentation automation. |
.github/workflows/frontend-build-pr.yaml |
Removes the major-branch push trigger. |
| * [Fork us!](https://help.github.com/articles/fork-a-repo/) | ||
| * Select the right branch. `main`(`2026.x`) for features and improvements or latest maintenance branch for bug fixes (`2026.2`) | ||
| * Code! Follow the coding standards defined [here](https://github.com/pimcore/pimcore/blob/2026.x/.php-cs-fixer.dist.php) and [here](https://github.com/pimcore/pimcore/blob/2026.x/doc/19_Development_Tools_and_Details/29_Testing/02_Core_Tests.md#perform-phpstan-analysis) | ||
| * Select the right branch. `main`(`2026.x`) for features and improvements or latest maintenance branch for bug fixes (`2025.4`) |
| * Select the right branch. `main`(`2026.x`) for features and improvements or latest maintenance branch for bug fixes (`2025.4`) | ||
| * [Send a pull request](https://help.github.com/articles/using-pull-requests/) from your fork’s branch to our repo branch. | ||
| * [Sign the CLA](https://cla-assistant.io/pimcore/pimcore) - see also below. | ||
| * Ensure that Github pipelines pass (linter, frontend build...) |
| grid.advanced-column.advancedColumns.stringReplace: String replace | ||
| grid.advanced-column.advancedColumns.substring: Substring | ||
| grid.advanced-column.advancedColumns.stringReplace: String Replace | ||
| grid.advanced-column.advancedColumns.substring: SubString |
| title={ ( | ||
| <ModalTitle iconName="settings"> | ||
| { t('listing.grid-config.title') } | ||
| Grid Config |
| )} | ||
| </Flex> | ||
| <Button onClick={ openElementSelector }> | ||
| Select Item |
Comment on lines
+16
to
+18
| import { type SelectProps } from '@Pimcore/components/select/select' | ||
| import { usePrevious } from '@Pimcore/utils/hooks/use-previous' | ||
| import { Select } from 'antd' |
|
|
||
| prevColumnKeysRef.current = currentKeys | ||
| }, [columns]) | ||
| const scrollSentinelRef = useScrollIntoViewOnAppend(columns, (column) => column.key) |
|
|
||
| prevColumnKeysRef.current = currentKeys | ||
| }, [columns]) | ||
| const scrollSentinelRef = useScrollIntoViewOnAppend(columns, (column) => column.key) |
| @@ -64,8 +63,6 @@ export const FieldsToAddPanel = ({ | |||
| data-testid={ dataTestId !== undefined ? `${dataTestId}-close` : undefined } | |||
| icon={ { value: 'collapse-sidebar', colorToken: 'colorPrimary' } } | |||
| onClick={ onClose } | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts all changes introduced by #3884 (and its follow-up fix #3903) that were merged into
2026.2but should not have been included.Commits reverted
Changes removed
.tabs--full-heightflex/absolute positioning on.ant-tabs-content-holder,.ant-tabs-content,.ant-tabs-tabpane)token.marginSMtoken.marginXXS🤖 Generated with Claude Code