Drop DOCS_GENERATOR_ACCESS_TOKEN from docs workflow, downgrade to pull_request - #3952
Merged
Merged
Conversation
|
pimcore-deployments
marked this pull request as draft
July 30, 2026 14:52
Collaborator
|
🚫 Issue-link guardrail failed — this PR has been converted to draft. Every PR must reference a tracking issue in
Add the link with a keyword in the PR description (not in a comment): https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests When fixed, press Ready for review to re-run the checks. |
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: LGTM. This securely migrates documentation checks to pull_request and removes the obsolete secret.
Changes:
- Uses the safer
pull_requesttrigger (.github/workflows/docs.yml:4). - Corrects workflow path filters (
:11,:20). - Removes the docs-generator token while retaining read-only permissions (
:23-30).
Review contract:
- Root cause addressed at the workflow boundary; no other local callers were found.
- No API or backward-compatibility impact.
- Workflow changes self-trigger through the corrected path filter.
- No documentation update is required.
- Remaining risk is limited to the existing mutable
@mainreference (:28).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Remove
DOCS_GENERATOR_ACCESS_TOKENfrom the docs workflow and downgrade its trigger frompull_request_targetto plainpull_request.The token was only needed to clone the private
docs-generator; since pimcore/workflows-collection-public#135 (merged) vendors sanitized public tooling, no secret is needed: read-only token, no secret-exposure surface. Tracked in pimcore/product-management#1321 (org-wide cleanup, template: pimcore/pimcore#19292).Changes
secrets: DOCS_GENERATOR_ACCESS_TOKENblock.pull_request_target→pull_request.pathsentry.github/workflows/new-docs.yml→docs.yml, so changes to the docs workflow itself trigger a docs run.Verification
The pattern is live-proven in pimcore/pimcore#19292 — its docs run is green on the exact tokenless
@mainpath. This PR's own docs run (triggered by the fixedpaths) verifies this repo.🤖 Generated with Claude Code