Repoint static analysis to reusable-static-analysis-unified - #61
Open
berfinyuksel wants to merge 9 commits into
Open
Repoint static analysis to reusable-static-analysis-unified#61berfinyuksel wants to merge 9 commits into
berfinyuksel wants to merge 9 commits into
Conversation
berfinyuksel
added
the
Skip Milestone Check
This was referenced Aug 26, 2026
Draft
Closed
…cancel superseded runs Rebased to 2.2 per the platform-version line map (2.2 = 2025.4 line; the previous base 2.0 is not on a valid line). Static-analysis referenced a reusable retired 2025-12-09 (zero-job start failures since); composer-analysis ran on every push to every branch. Refs DevOps-Tasks#47, DevOps-Tasks#44. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
berfinyuksel
force-pushed
the
ci/consolidated-workflow-fixes
branch
from
August 26, 2026 14:14
b588f3e to
0d9a02c
Compare
|
DevOps-Tasks#44 ideas 3 and 5: paths-ignore for docs/markdown where no path filter existed (no required checks gate these workflows on this branch - verified), and timeout-minutes on inline jobs so a hanging job cannot burn the 6h default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Final consolidated adjustments per review: the concurrency group uses the PR number as DevOps-Tasks#44 specifies (head_ref collides across same-named fork branches - Copilot review), pre-existing branch filters are preserved verbatim, and timeouts on test/analysis jobs are 60 minutes so no legitimate long leg is ever killed (setup jobs stay short). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The filter-restore step wrongly re-added feature-* from the old file; the regenerated workflow deliberately scopes push to version branches (DevOps-Tasks#44 idea 1). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DevOps-Tasks#44 / prep for stacked PRs (DevOps-Tasks#48): pull_request base-branch filter so mid-stack PRs (base = another feature branch) skip the heavy suites. Normal PRs target version branches and are unaffected. No required checks gate these workflows (verified). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Per review: identical workflows must look identical unless there is a reason not to. pull_request runs for every base branch again (developers expect the suites on PRs from any branch name); push stays scoped to version branches; every job timeout is uniformly 30 minutes; concurrency is uniformly keyed by PR number. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
An unscoped push trigger runs on every branch push - the opposite of DevOps-Tasks#44 idea 1. Scoping restored (original list for pre-existing files, version branches for the modernized static analysis). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Per review of the drift map: .bak files removed, obsolete frontend/npm workflows removed, cla/docs/poeditor/cs-fixer/copilot-setup/stale synced to the 2026.x content and filenames, and static analysis gets the uniform paths-ignore (assets, assets-customized, doc, install, src/Resources/public, **.md). Matrix-bearing workflows keep their era-specific content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Per review: what 2026.x dropped, the 2025 lines drop as well. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the silently-dead static analysis (pimcore/DevOps-Tasks#47): this branch's caller referenced
reusable-static-analysis-centralized.yaml, retired from workflows-collection-public on 2025-12-09 — every run since start-failed with zero jobs and no logs. Replaced with the unified pattern validated on pimcore/web2print-tools#121 (two passing PHPStan legs there, first since December).Also carries pimcore/DevOps-Tasks#44 ideas 1–3 within the same file: push scoped to version branches,
concurrency+cancel-in-progress, paths-ignore for docs/assets/markdown. Matrix is derived from this branch's own composer.json; the matching matrix-config key was verified to exist. Forward-merge up the version chain follows after merge.Expected on this PR: static analysis runs real matrix legs again.