feat(safe): support dynamic owners#528
Open
mouseless0x wants to merge 2 commits into
Open
Conversation
- Add dynamic owner types and export them for safe accounts - Encode contract owners as dynamic Safe signatures in signing flows - Add integration coverage for v0.7 dynamic owner user operations
🦋 Changeset detectedLatest commit: de8881e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 78.41% 78.55% +0.13%
==========================================
Files 105 105
Lines 8988 9017 +29
Branches 570 584 +14
==========================================
+ Hits 7048 7083 +35
+ Misses 1914 1907 -7
- Partials 26 27 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
- Replace the mock ERC-1271 code with a signature-dependent validator - Use a fixed marker signature to verify the dynamic owner path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dynamic owner types and export them for safe accounts
Encode contract owners as dynamic Safe signatures in signing flows
Add integration coverage for v0.7 dynamic owner user operations