-
Notifications
You must be signed in to change notification settings - Fork 6
Interstate75 Duo Support & Firmware #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gadgetoid
wants to merge
28
commits into
main
Choose a base branch
from
feature/duo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ZodiusInfuser <[email protected]>
93ef7b0
to
8399528
Compare
Set OE pin on teardown- though I still end up in situations where LEDs are stuck on with a soft reset!
Stock clock update only from ~4.75ms to ~4.00ms.
Run PIO clock at div 1.0, faster clock = less flicker + probably also lower brightness. Crank the brightness a little. Some minor performance tweaks.
Spread the interlaced panel pixels across two "synced" state machines on each PIO. Remove the need to manually interlace pixels, reduce the PIO instruction count significantly, parallelise the shifting out of pixel bits, remove the need for a dummy pixel, and so on...
Remove set_pixel/clear since we use PicoGraphics exclusively. Remove features relating to alternate panel types and settings.
Move front to back buffer copy onto Core1. Introduces the potential for tearing, but gives the user more time on Core0 for shinies.
Currently crashes on Core1, possibly due to stack overflow?
Not passing a PicoGraphics instance into the frame_convert callback seemed to make Core1 happy. Reimplement the workaround as a blocking/non-blocking option. Default to non-blocking since it's relatively easy to work with.
This is a crude stop-gap fix to the Duo browning out when connected to my MacBook. Ideally we'd compute the gamma table on the fly and ramp up brightness until we see a voltage drop. (This would also allow for fine-grained user brightness without losing fidelity.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to see here... 👀
TODO
USB_SIE_STATUS_CONNECTED
rather than smart brightness adaptation. It could be better...Crude Power Drop on USB Data
For posterity here's a hack which checks the "connected" bit of the USB
SIE_STATUS
register.It should probably start low and raise the brightness if USB has not been detected after a timeout...