feat: support ordinal queries (first/second/last) - #30
Closed
Djain912 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #25 by supporting ordinal queries to select an element by position among matching candidates.
What changed
first,second,third, numeric ordinals (1st,2nd,3rd, ...), andlast.first name).Example queries now supported
second buttonthird menu itemlast input fieldValidation
go test ./internal/engine -run "TestParseOrdinalConstraint_BasicPatterns|TestCombinedMatcher_OrdinalQuery_SecondButton|TestCombinedMatcher_OrdinalQuery_LastInputField|TestCombinedMatcher_OrdinalQuery_OutOfRangeReturnsNoMatch|TestCombinedMatcher_OrdinalGuard_DoesNotTreatFirstNameAsOrdinal" -count=1go test -count=1 ./...go vet ./...go build ./...go build -o semantic.exe ./cmd/semanticgo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0 runsecond button-> second result by orderlast input field-> last result by orderfifth button(out-of-range) -> no resultEnvironment note
go test -race ./...) is blocked by local 64-bit cgo toolchain availability (cc1.exe ... 64-bit mode not compiled in).Closes #25