Add Create Index Error + Optional-argument integration tests for Pod + Serverless #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
requested review from
rohanshah18,
ssmith-pc,
aulorbe and
jhamon
aulorbe
reviewed
Mar 20, 2024
aulorbe
reviewed
Mar 20, 2024
...tion/java/io/pinecone/integration/controlPlane/pod/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...tion/java/io/pinecone/integration/controlPlane/pod/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...tion/java/io/pinecone/integration/controlPlane/pod/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...tion/java/io/pinecone/integration/controlPlane/pod/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...tion/java/io/pinecone/integration/controlPlane/pod/CreateDescribeListAndDeleteIndexTest.java
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...va/io/pinecone/integration/controlPlane/serverless/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...va/io/pinecone/integration/controlPlane/serverless/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
reviewed
Mar 20, 2024
...va/io/pinecone/integration/controlPlane/serverless/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
aulorbe
approved these changes
Mar 20, 2024
...va/io/pinecone/integration/controlPlane/serverless/CreateDescribeListAndDeleteIndexTest.java
Outdated
Show resolved
Hide resolved
rohanshah18
approved these changes
Mar 20, 2024
…d metric, add some constants for specific configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
createIndexintegration tests are somewhat minimal and we've wanted to add thorough testing for error-cases, and optional configuration arguments for both pod and serverless indexes.Solution
Update
integration.controlPlane.pod.CreateDescribeAndDeleteIndexTestandintegration.controlPlane.serverless.CreateDescribeAndDeleteIndexTestto include additional tests validating error-conditions, and creating indexes with optional arguments.Type of Change
Test Plan
run
gradle integrationTestor validate the tests are run as part of theprworkflow in GitHub CI.