Skip to content

Add data plane tests for serverless index #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Mar 20, 2024

Problem

Not all of the dataplane operations for serverless index are covered as a part of current test suite.

Solution

Add integration and error tests for data plane operations for serverless index. As a part of this PR, I have added:

  1. Error tests for query and upsert data plane operations.
  2. Integration tests for all data plane operations for both async and blocking stubs.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above:
    Added more tests

Test Plan

Ran integration tests locally and on CI

@rohanshah18 rohanshah18 marked this pull request as ready for review March 20, 2024 18:17
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding additional data plane tests, these look good to me. However, I'm confused about the mocking in integration tests.

@rohanshah18 rohanshah18 merged commit 4581d5e into main Mar 21, 2024
6 of 9 checks passed
@rohanshah18 rohanshah18 deleted the rshah/addServerlessTests branch March 21, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants