Add retry config for urllib3 requests #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to automatically retry when errors occur
Solution
Implement
urllib3
retry configuration. We implemented the backup calculation with jitter ourselves because this is not available for all versions ofurllib3
that the SDK uses.Type of Change
Test Plan
I created a mock server in
scripts/text-server.py
that simulates a high rate of failures (80% failure, only 1 in 5 requests succeed).poetry run python3 scripts/test-server.py
Then I made some requests and observed logging to see what was going on.