resource control: support more mode for BURSTABLE#20020
Merged
ti-chi-bot[bot] merged 28 commits intopingcap:masterfrom Aug 19, 2025
Merged
resource control: support more mode for BURSTABLE#20020ti-chi-bot[bot] merged 28 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 28 commits intopingcap:masterfrom
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
ti-chi-bot
bot
added
missing-translation-status
hfxsd
added
translation/doing
songrijie
reviewed
Mar 12, 2025
songrijie
reviewed
Mar 12, 2025
songrijie
reviewed
Mar 12, 2025
Co-authored-by: Roger Song <roger.song@pingcap.com>
Co-authored-by: Roger Song <roger.song@pingcap.com>
Co-authored-by: Roger Song <roger.song@pingcap.com>
songrijie
approved these changes
Mar 12, 2025
|
@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hfxsd
added
do-not-merge/hold
Contributor
Author
|
@hfxsd ptal |
16 tasks
lilin90
reviewed
Jun 26, 2025
songrijie
reviewed
Jun 27, 2025
| +---------+------------+----------+----------------+-------------+------------+ | ||
| | NAME | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND | | ||
| +---------+------------+----------+----------------+-------------+------------+ | ||
| | default | UNLIMITED | MEDIUM | YES(UNLIMITED) | NULL | NULL | |
Contributor
There was a problem hiding this comment.
这里 BURSTABLE 是不是就只显示 OFF, UNLIMITED, MODERATED。 用括号不太合适。 @lhy1024
Contributor
Author
There was a problem hiding this comment.
要修改显示结果么？不过不知道代码还能不能合进去了
hfxsd
reviewed
Jul 3, 2025
hfxsd
reviewed
Jul 3, 2025
hfxsd
reviewed
Jul 3, 2025
hfxsd
reviewed
Jul 3, 2025
hfxsd
reviewed
Jul 3, 2025
hfxsd
reviewed
Jul 3, 2025
hfxsd
approved these changes
Jul 3, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Member
|
This PR is ready for merging. |
Member
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
lilin90
reviewed
Aug 19, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?