Revert "tiproxy: fix image link in tiproxy-load-balance.md"#21208
Revert "tiproxy: fix image link in tiproxy-load-balance.md"#21208ti-chi-bot[bot] merged 1 commit intorelease-8.5from
Conversation
This reverts commit 2d585aa.
ti-chi-bot
bot
added
contribution
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to undo a previous modification to an image link within the tiproxy-load-balance.md documentation file. The change restores the image's source URL to a preferred or correct path, implying that the link introduced by the reverted pull request was problematic or incorrect.
Highlights
- Revert Previous Change: This pull request fully reverts the changes introduced by pull request
pingcap/docs#21205. - Image Link Correction: The image source URL for the 'Label-based Load Balancing' diagram in
tiproxy/tiproxy-load-balance.mdhas been changed. Specifically, the link is updated from agithub.comblob URL to adocs-download.pingcap.comURL, restoring the image link to its state before the reverted PR.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change to an image link in tiproxy-load-balance.md. The reverted link uses a GitHub blob URL, which is typically unstable for documentation builds. The review suggests restoring the link to use the stable docs-download.pingcap.com domain to ensure the image displays correctly in the published documentation.
hfxsd
added
translation/no-need
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Reverts #21205