pd: add callee_id to RequestHeader #1379
Open
+128
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`callee_id` is used to indicate the expected server ID to receive the request. The server SHOULD check if the `callee_id` matches its own ID, normally it's the client url address of the server. We encountered an issue where a tso client caches the stale DNS result and the new tso server takes over the old server's network address, then the tso client connects to the new tso server (a follower) with the actual leader's hostname, creating a hallucination that the leader is not the leader anymore. If the client meets this case, it might never get out of it if it doesn't refresh its DNS cache by reconnecting. Signed-off-by: iosmanthus <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callee_idis used to indicate the expected server ID to receive the request. The server SHOULD check if thecallee_idmatches its own ID, normally it's the client url address of the server. We encountered an issue where a tso client caches the stale DNS result and the new tso server takes over the old server's network address. Then, the tso client connects to the new tso server (a follower) with the actual leader's hostname, creating a hallucination that the leader is not the leader anymore. If the client meets this case, it might never get out of it if it doesn't refresh its DNS cache by reconnecting. ref tikv/pd#9894