tikvpv, kvrpcpb: Add RawCompareAndDelete API#1434
Open
healthwaite wants to merge 1 commit intopingcap:masterfrom
Open
tikvpv, kvrpcpb: Add RawCompareAndDelete API#1434healthwaite wants to merge 1 commit intopingcap:masterfrom
healthwaite wants to merge 1 commit intopingcap:masterfrom
Conversation
Signed-off-by: Alex Reid <areid@akamai.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit re-implements compare-and-delete by creating a new
RawCompareAndDeleteAPI. Previously compare-and-delete piggy-backed on theRawCompareAndSwapAPI by introducing adeleteflag into theRawCASRequestmessage. As described in issue tikv/tikv#19462 this can cause silent data corruption if a newer client is talking to a server which doesn't support compare-and-delete. In this PR:RawCADRequest/ResponsemessagesRawCompareAndDeleteRPCdeleteflag inRawCASRequest: in practice we could actually just remove this field as no version of the server of client has been release which makes use of it. Let me know if you'd prefer to remove it.Accompanying tikv PR: tikv/tikv#19465
Accompanying issue: tikv/tikv#19462