Skip to content

chore: replace deprecated PingCAP download domains#4689

Open
wuhuizuo wants to merge 2 commits intopingcap:masterfrom
wuhuizuo:fix/update-download-domains-master
Open

chore: replace deprecated PingCAP download domains#4689
wuhuizuo wants to merge 2 commits intopingcap:masterfrom
wuhuizuo:fix/update-download-domains-master

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 2, 2026

Summary

  • replace deprecated download.pingcap.org references with download.pingcap.com
  • replace deprecated charts.pingcap.org references with charts.pingcap.com where present
  • keep the existing paths and protocols unchanged

Validation

  • git diff --check
  • verified no remaining download.pingcap.org / charts.pingcap.org references in the patched branch

Summary by CodeRabbit

  • Chores
    • Updated integration test binary download links to a new download domain and upgraded referenced community binaries from v6.0.0 to v8.5.0 to ensure tests fetch current releases.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 2, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign flowbehappy for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the download domain from pingcap.org to pingcap.com in the integration tests documentation and the binary download script. The review feedback suggests updating the example version in the README to align with current defaults and refactoring the script to use a local variable for the base URL to improve maintainability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 550b4926-98e9-4b07-a8fd-7ed284511b2b

📥 Commits

Reviewing files that changed from the base of the PR and between 4588ae2 and 1fdce37.

📒 Files selected for processing (1)
  • tests/integration_tests/README.md
✅ Files skipped from review due to trivial changes (1)
  • tests/integration_tests/README.md

📝 Walkthrough

Walkthrough

Updated TiDB community binary references: tests/integration_tests/README.md bumped toolkit/server tarball versions from v6.0.0 to v8.5.0 and switched download domain to download.pingcap.com; tests/scripts/download-integration-test-binaries.sh changed download domain from download.pingcap.org to download.pingcap.com.

Changes

Cohort / File(s) Summary
README version + domain
tests/integration_tests/README.md
Bumped referenced TiDB community tarballs from v6.0.0 to v8.5.0 and updated download URLs to download.pingcap.com.
Script domain change
tests/scripts/download-integration-test-binaries.sh
Replaced download domain download.pingcap.orgdownload.pingcap.com for toolkit and server tarball URLs; filenames and extraction logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through links with nimble paws,
From old v6 to v8 applause,
Domains realigned, the downloads hum,
Tests ready now — here I come! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing required sections from the template (Issue Number, What is changed and how it works, Tests, Questions, Release note) and does not follow the expected structure. Add required template sections including Issue Number linking, detailed explanation of changes, test type, answers to compatibility/documentation questions, and release note.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: replacing deprecated PingCAP download domains, which directly matches the core purpose of the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant