metrics,scripts: keep TiCDC dashboard titles consistent

[tenfyzhong]

What problem does this PR solve?

Issue Number: close #4764

TiCDC dashboards still hardcode test-cluster in their titles, and the next-gen metrics generator can silently miss required title or label substitutions when the base title template changes.

What is changed and how it works?

• Updates metrics/grafana/ticdc_new_arch.json and metrics/nextgengrafana/ticdc_new_arch_next_gen.json to use ${DS_TEST-CLUSTER}-TiCDC-New-Arch.
• Updates metrics/nextgengrafana/ticdc_new_arch_with_keyspace_name.json to use ${DS_TEST-CLUSTER}-TiCDC-New-Arch-KeyspaceName.
• Updates scripts/generate-next-gen-metrics.sh so the keyspace-title replacement matches the current base title.
• Adds fail-fast checks to require -KeyspaceName in the generated user dashboard and sharedpool_id in the generated shared dashboard.

Check List

Tests

• Manual test (add detailed scripts or steps below)

Manual test steps:

• bash ./scripts/generate-next-gen-metrics.sh
• jq empty metrics/grafana/ticdc_new_arch.json metrics/nextgengrafana/ticdc_new_arch_next_gen.json metrics/nextgengrafana/ticdc_new_arch_with_keyspace_name.json
• grep -F -- '-KeyspaceName' metrics/nextgengrafana/ticdc_new_arch_with_keyspace_name.json
• grep -F -- 'sharedpool_id' metrics/nextgengrafana/ticdc_new_arch_next_gen.json
• git diff --check

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No additional documentation is needed.

Release note

None

[coderabbitai]

📝 Walkthrough

Walkthrough

Three Grafana dashboard JSON files are updated to use a templated datasource variable in the title field instead of a hardcoded cluster name. The title pattern changes from test-cluster-TiCDC-New-Arch to ${DS_TEST-CLUSTER}-cluster-TiCDC-New-Arch, enabling dynamic title rendering based on the selected datasource.

Changes

Cohort / File(s)	Summary
Grafana Dashboard Title Updates metrics/grafana/ticdc_new_arch.json, metrics/nextgengrafana/ticdc_new_arch_next_gen.json, metrics/nextgengrafana/ticdc_new_arch_with_keyspace_name.json	Updated title field to use ${DS_TEST-CLUSTER} variable, replacing hardcoded test-cluster reference with templated datasource variable for dynamic cluster name resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved

Suggested reviewers

• wk989898

Poem

🐇 Hop hop, the titles now dance with the light,
No more hardcoded clusters, just variables bright!
Each datasource now gets its proper name,
TiCDC dashboards play the templating game! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR successfully implements the solution proposed in issue #4764: all three affected dashboard title fields now interpolate ${DS_TEST-CLUSTER} as required.
Out of Scope Changes check	✅ Passed	All changes are scoped to updating the title fields of three Grafana dashboard JSON files as specified in issue #4764; no extraneous modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change—updating TiCDC dashboard titles to use a datasource variable instead of hardcoding 'test-cluster'.
Description check	✅ Passed	The description includes issue reference, detailed change explanation, manual test steps, and answers to all required template questions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request replaces the hardcoded "test-cluster" prefix with the "${DS_TEST-CLUSTER}" variable in several Grafana dashboard titles. Feedback suggests removing the redundant "-cluster" suffix from the titles, as the variable likely already includes it, to avoid repetitive naming like "test-cluster-cluster".

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [3AceShowHand,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2026-04-08 07:32:43.063664483 +0000 UTC m=+941568.269024540: ☑️ agreed by 3AceShowHand.
• 2026-04-08 08:05:50.499662937 +0000 UTC m=+943555.705022984: ☑️ agreed by lidezhu.

[tenfyzhong]

/tide

[ti-chi-bot]

@tenfyzhong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test	cf6ef50	link	unknown	/test pull-unit-test
pull-cdc-pulsar-integration-light	cf6ef50	link	unknown	/test pull-cdc-pulsar-integration-light
pull-cdc-mysql-integration-light-next-gen	cf6ef50	link	unknown	/test pull-cdc-mysql-integration-light-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.