Skip to content

test: stabilize signal resolved test #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongyunyan wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −7
Open

test: stabilize signal resolved test #4773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions pkg/eventservice/event_broker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,12 @@ func TestProcessTableTriggerDispatcherSendsSignalResolvedWhenNoForwardRangeAndNo

changefeed := broker.getOrSetChangefeedStatus(info.GetChangefeedID(), info.GetSyncPointInterval())
dispatcher := newDispatcherStat(info, 1, 1, nil, changefeed)
dispatcher.lastSentResolvedTsTime.Store(time.Now().Add(-defaultSendResolvedTsInterval - time.Second))
// Keep the test focused on the signal resolved path instead of coupling it with
// the separate handshake behavior.
dispatcher.seq.Store(1)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using the setHandshaked() method instead of directly storing a value in the unexported seq field. This is more idiomatic, ensures consistency with many other tests in this file (e.g., lines 172, 321, 400, 700), and provides better encapsulation of the dispatcher's handshake state.

Suggested change
dispatcher.seq.Store(1)
dispatcher.setHandshaked()

// Use the zero time to bypass the rate limit deterministically without depending
// on wall clock timing.
dispatcher.lastSentResolvedTsTime.Store(time.Time{})

dispatcherPtr := &atomic.Pointer[dispatcherStat]{}
dispatcherPtr.Store(dispatcher)
Expand All @@ -1497,12 +1502,10 @@ func TestProcessTableTriggerDispatcherSendsSignalResolvedWhenNoForwardRangeAndNo

broker.processTableTriggerDispatcher(context.Background(), dispatcher.id, dispatcher)

require.Equal(t, 2, len(broker.messageCh[dispatcher.messageWorkerIndex]))
first := <-broker.messageCh[dispatcher.messageWorkerIndex]
second := <-broker.messageCh[dispatcher.messageWorkerIndex]
require.Equal(t, event.TypeHandshakeEvent, first.msgType)
require.Equal(t, event.TypeResolvedEvent, second.msgType)
require.Equal(t, ts10, second.resolvedTsEvent.ResolvedTs)
require.Equal(t, 1, len(broker.messageCh[dispatcher.messageWorkerIndex]))
msg := <-broker.messageCh[dispatcher.messageWorkerIndex]
require.Equal(t, event.TypeResolvedEvent, msg.msgType)
require.Equal(t, ts10, msg.resolvedTsEvent.ResolvedTs)
require.Equal(t, ts10, dispatcher.sentResolvedTs.Load())
require.Equal(t, ts20, dispatcher.nextSyncPoint.Load())
}
Expand Down
Loading