go.mod: upgrade tidb parser to latest#4774
Conversation
Upgrade github.com/pingcap/tidb/pkg/parser from v0.0.0-20251121075944-8f2630e53d5d to v0.0.0-20260409042751-e0b4e44570cd.\n\nValidation:\n- make fmt\n- go test --tags=intest ././cmd/kafka-consumer ././cmd/pulsar-consumer ././cmd/util ././downstreamadapter/dispatcher ././downstreamadapter/sink/cloudstorage ././downstreamadapter/sink/columnselector ././downstreamadapter/sink/mysql ././downstreamadapter/sink/mysql/causality ././logservice/schemastore ././pkg/applier ././pkg/binlog-filter ././pkg/common ././pkg/common/event ././pkg/diff ././pkg/errors ././pkg/filter ././pkg/redo/reader ././pkg/sink/cloudstorage ././pkg/sink/codec/avro ././pkg/sink/codec/canal ././pkg/sink/codec/common ././pkg/sink/codec/csv ././pkg/sink/codec/debezium ././pkg/sink/codec/open ././pkg/sink/codec/simple ././pkg/sink/mysql ././pkg/sink/sqlmodel ././tests/integration_tests/cdc/dailytest ././tests/integration_tests/debezium01/src ././tests/utils/checksum_checker \n- go test --tags=intest ./downstreamadapter/dispatcher -run '^$'\n\nNote: TestRedoBatchDMLEventsPartialFlush fails on both the upgraded branch and the unchanged upstream/master baseline, so it is treated as a pre-existing test issue rather than a parser regression.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA dependency version update in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test pull-cdc-mysql-integration-heavy |
|
/test pull-cdc-mysql-integration-light |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
There was a problem hiding this comment.
Code Review
This pull request updates the github.com/pingcap/tidb/pkg/parser dependency. The review feedback correctly points out that the go.sum file still contains obsolete entries from the previous dependency version and suggests running go mod tidy to clean these up.
| github.com/pingcap/tidb v1.1.0-beta.0.20251121075944-8f2630e53d5d | ||
| github.com/pingcap/tidb-dashboard v0.0.0-20240326110213-9768844ff5d7 | ||
| github.com/pingcap/tidb/pkg/parser v0.0.0-20251121075944-8f2630e53d5d | ||
| github.com/pingcap/tidb/pkg/parser v0.0.0-20260409042751-e0b4e44570cd |
|
@hongyunyan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issue Number: N/A
Background
TiCDC currently pins
github.com/pingcap/tidb/pkg/parsertov0.0.0-20251121075944-8f2630e53d5d.Motivation
We want to move the parser dependency to the latest upstream version so TiCDC can pick up the newest parser changes without widening the dependency update beyond what is required for this task.
Summary
github.com/pingcap/tidb/pkg/parsertov0.0.0-20260409042751-e0b4e44570cdgo.sumfor the new parser module checksumsgithub.com/pingcap/tidbunchanged because the parser-only bump did not require a wider module updateTesting
make fmtgo test --tags=intestfor all packages that directly importgithub.com/pingcap/tidb/pkg/parser...excepttests/integration_tests/...go test --tags=intest ./downstreamadapter/dispatcher -run ^Notes
TestRedoBatchDMLEventsPartialFlushin./downstreamadapter/dispatcherfails on both this branch and the unchangedupstream/masterbaseline, so it was treated as a pre-existing test issue rather than a regression from this parser upgrade.release-note
Summary by CodeRabbit