Skip to content

go.mod: upgrade tidb parser to latest#4774

Open
hongyunyan wants to merge 1 commit intopingcap:masterfrom
hongyunyan:codex/upgrade-tidb-parser-latest
Open

go.mod: upgrade tidb parser to latest#4774
hongyunyan wants to merge 1 commit intopingcap:masterfrom
hongyunyan:codex/upgrade-tidb-parser-latest

Conversation

@hongyunyan
Copy link
Copy Markdown
Collaborator

@hongyunyan hongyunyan commented Apr 9, 2026

Issue Number: N/A

Background

TiCDC currently pins github.com/pingcap/tidb/pkg/parser to v0.0.0-20251121075944-8f2630e53d5d.

Motivation

We want to move the parser dependency to the latest upstream version so TiCDC can pick up the newest parser changes without widening the dependency update beyond what is required for this task.

Summary

  • upgrade github.com/pingcap/tidb/pkg/parser to v0.0.0-20260409042751-e0b4e44570cd
  • refresh go.sum for the new parser module checksums
  • keep github.com/pingcap/tidb unchanged because the parser-only bump did not require a wider module update

Testing

  • make fmt
  • go test --tags=intest for all packages that directly import github.com/pingcap/tidb/pkg/parser... except tests/integration_tests/...
  • go test --tags=intest ./downstreamadapter/dispatcher -run ^

Notes

TestRedoBatchDMLEventsPartialFlush in ./downstreamadapter/dispatcher fails on both this branch and the unchanged upstream/master baseline, so it was treated as a pre-existing test issue rather than a regression from this parser upgrade.

release-note

None

Summary by CodeRabbit

  • Chores
    • Updated dependencies to latest versions for improved stability and performance.

Upgrade github.com/pingcap/tidb/pkg/parser from v0.0.0-20251121075944-8f2630e53d5d to v0.0.0-20260409042751-e0b4e44570cd.\n\nValidation:\n- make fmt\n- go test --tags=intest ././cmd/kafka-consumer ././cmd/pulsar-consumer ././cmd/util ././downstreamadapter/dispatcher ././downstreamadapter/sink/cloudstorage ././downstreamadapter/sink/columnselector ././downstreamadapter/sink/mysql ././downstreamadapter/sink/mysql/causality ././logservice/schemastore ././pkg/applier ././pkg/binlog-filter ././pkg/common ././pkg/common/event ././pkg/diff ././pkg/errors ././pkg/filter ././pkg/redo/reader ././pkg/sink/cloudstorage ././pkg/sink/codec/avro ././pkg/sink/codec/canal ././pkg/sink/codec/common ././pkg/sink/codec/csv ././pkg/sink/codec/debezium ././pkg/sink/codec/open ././pkg/sink/codec/simple ././pkg/sink/mysql ././pkg/sink/sqlmodel ././tests/integration_tests/cdc/dailytest ././tests/integration_tests/debezium01/src ././tests/utils/checksum_checker \n- go test --tags=intest ./downstreamadapter/dispatcher -run '^$'\n\nNote: TestRedoBatchDMLEventsPartialFlush fails on both the upgraded branch and the unchanged upstream/master baseline, so it is treated as a pre-existing test issue rather than a parser regression.
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 9, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lidezhu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6315c777-920b-4803-b6f0-e4aba867b5a5

📥 Commits

Reviewing files that changed from the base of the PR and between 0a418b4 and b28ff94.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

A dependency version update in go.mod bumps the github.com/pingcap/tidb/pkg/parser package from one pseudo-version to another, reflecting a change in the underlying parser package source.

Changes

Cohort / File(s) Summary
Dependency Version Update
go.mod
Updated github.com/pingcap/tidb/pkg/parser from v0.0.0-20251121075944-8f2630e53d5d to v0.0.0-20260409042751-e0b4e44570cd.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 With twitching nose, I celebrate,
A parser update, isn't it great?
One tiny hop to versions new,
Our dependencies bloom fresh and true! 🌱✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: upgrading the TiDB parser dependency to the latest version.
Description check ✅ Passed The description is largely complete with background, motivation, summary, testing details, and release notes, though it deviates from the required template by using a custom format instead of the template's "What problem does this PR solve?" and "What is changed and how it works?" sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hongyunyan
Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-mysql-integration-heavy

@hongyunyan
Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-mysql-integration-light

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/pingcap/tidb/pkg/parser dependency. The review feedback correctly points out that the go.sum file still contains obsolete entries from the previous dependency version and suggests running go mod tidy to clean these up.

github.com/pingcap/tidb v1.1.0-beta.0.20251121075944-8f2630e53d5d
github.com/pingcap/tidb-dashboard v0.0.0-20240326110213-9768844ff5d7
github.com/pingcap/tidb/pkg/parser v0.0.0-20251121075944-8f2630e53d5d
github.com/pingcap/tidb/pkg/parser v0.0.0-20260409042751-e0b4e44570cd
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

After updating dependencies, please run go mod tidy to remove obsolete entries from go.sum. The checksums for the previous version of github.com/pingcap/tidb/pkg/parser are still present in go.sum, and tidying the module will clean this up.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

@hongyunyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-mysql-integration-light b28ff94 link true /test pull-cdc-mysql-integration-light
pull-cdc-mysql-integration-heavy b28ff94 link true /test pull-cdc-mysql-integration-heavy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant