Skip to content

metrics,scripts: sync next gen shared dashboard UID#4776

Closed
tenfyzhong wants to merge 1 commit intopingcap:masterfrom
tenfyzhong:metrics-sync-next-gen-shared-dashboard-uid
Closed

metrics,scripts: sync next gen shared dashboard UID#4776
tenfyzhong wants to merge 1 commit intopingcap:masterfrom
tenfyzhong:metrics-sync-next-gen-shared-dashboard-uid

Conversation

@tenfyzhong
Copy link
Copy Markdown
Collaborator

@tenfyzhong tenfyzhong commented Apr 9, 2026

What problem does this PR solve?

Issue Number: close #4775

What is changed and how it works?

  • update scripts/generate-next-gen-metrics.sh so it rewrites the shared-scope next-gen dashboard UID during generation
  • regenerate metrics/nextgengrafana/ticdc_new_arch_next_gen.json with the refreshed shared dashboard UID
  • keep generate-next-gen-grafana output reproducible under make check

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated dashboard configuration identifiers in monitoring and metrics generation components.

Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 394be942-5df2-4fdc-8879-81cb7fc7648c

📥 Commits

Reviewing files that changed from the base of the PR and between 0a418b4 and 5471709.

📒 Files selected for processing (2)
  • metrics/nextgengrafana/ticdc_new_arch_next_gen.json
  • scripts/generate-next-gen-metrics.sh

📝 Walkthrough

Walkthrough

The changes align the next-gen shared dashboard UID regeneration across the build system. The dashboard JSON's uid field was updated from YiGL8hBZ0aac to zHSo4WLgHDpS, and a corresponding sed substitution was added to the generator script to ensure reproducibility.

Changes

Cohort / File(s) Summary
Dashboard UID Update
metrics/nextgengrafana/ticdc_new_arch_next_gen.json
Updated the uid field value to match the refreshed shared-scope dashboard identifier.
Generator Script Alignment
scripts/generate-next-gen-metrics.sh
Added sed substitution to rewrite the shared dashboard UID (YiGL8hBZ0aaczHSo4WLgHDpS) during regeneration, mirroring existing user-scope UID rewriting logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

Suggested reviewers

  • wk989898

Poem

🐰 A UID that danced out of sync,
Now tethered tight by script and link,
The generator remembers to align,
No more drift—all dashboards shine! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: synchronizing the next-gen shared dashboard UID across metrics and scripts.
Description check ✅ Passed The description covers the problem, changes, and rationale, referencing issue #4775, listing the files modified, and explaining the purpose (reproducibility under make check).
Linked Issues check ✅ Passed The PR successfully addresses the linked issue #4775 by updating the script to rewrite the shared-scope dashboard UID and regenerating the JSON file with the new UID.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the requirements in issue #4775: updating the script and regenerating the dashboard JSON to keep UIDs synchronized.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tenfyzhong
Copy link
Copy Markdown
Collaborator Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 9, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the UID for the TiCDC-New-Arch Grafana dashboard in metrics/nextgengrafana/ticdc_new_arch_next_gen.json and modifies scripts/generate-next-gen-metrics.sh to reflect this change. The review suggests an improvement to define the new dashboard UID as a variable in the script for better maintainability, rather than hardcoding it directly in the sed command.

' "$NEXT_GEN_SHARED_FILE" >"$NEXT_GEN_USER_FILE"

"$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/\${DS_TEST-CLUSTER}-TiCDC-New-Arch/&-KeyspaceName/" "$NEXT_GEN_USER_FILE"
"$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/YiGL8hBZ0aac/zHSo4WLgHDpS/" "$NEXT_GEN_SHARED_FILE"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The sed command uses a hardcoded UID. It is better to define this UID as a variable at the top of the script to improve maintainability and avoid potential errors if the UID needs to be updated in multiple places.

Suggested change
"$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/YiGL8hBZ0aac/zHSo4WLgHDpS/" "$NEXT_GEN_SHARED_FILE"
SHARED_DASHBOARD_UID="zHSo4WLgHDpS"
"$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/YiGL8hBZ0aac/$SHARED_DASHBOARD_UID/" "$NEXT_GEN_SHARED_FILE"

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 9, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-09 06:49:06.751483595 +0000 UTC m=+1025351.956843642: ☑️ agreed by 3AceShowHand.
  • 2026-04-09 07:01:51.156289484 +0000 UTC m=+1026116.361649541: ☑️ agreed by lidezhu.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

@tenfyzhong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-mysql-integration-heavy 5471709 link unknown /test pull-cdc-mysql-integration-heavy
pull-cdc-kafka-integration-heavy 5471709 link unknown /test pull-cdc-kafka-integration-heavy
pull-cdc-mysql-integration-light 5471709 link unknown /test pull-cdc-mysql-integration-light

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tenfyzhong tenfyzhong closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Keep next-gen shared dashboard UID aligned with generator

3 participants