metrics,scripts: sync next gen shared dashboard UID#4776
metrics,scripts: sync next gen shared dashboard UID#4776tenfyzhong wants to merge 1 commit intopingcap:masterfrom
Conversation
Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes align the next-gen shared dashboard UID regeneration across the build system. The dashboard JSON's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/check-issue-triage-complete |
There was a problem hiding this comment.
Code Review
This pull request updates the UID for the TiCDC-New-Arch Grafana dashboard in metrics/nextgengrafana/ticdc_new_arch_next_gen.json and modifies scripts/generate-next-gen-metrics.sh to reflect this change. The review suggests an improvement to define the new dashboard UID as a variable in the script for better maintainability, rather than hardcoding it directly in the sed command.
| ' "$NEXT_GEN_SHARED_FILE" >"$NEXT_GEN_USER_FILE" | ||
|
|
||
| "$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/\${DS_TEST-CLUSTER}-TiCDC-New-Arch/&-KeyspaceName/" "$NEXT_GEN_USER_FILE" | ||
| "$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/YiGL8hBZ0aac/zHSo4WLgHDpS/" "$NEXT_GEN_SHARED_FILE" |
There was a problem hiding this comment.
The sed command uses a hardcoded UID. It is better to define this UID as a variable at the top of the script to improve maintainability and avoid potential errors if the UID needs to be updated in multiple places.
| "$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/YiGL8hBZ0aac/zHSo4WLgHDpS/" "$NEXT_GEN_SHARED_FILE" | |
| SHARED_DASHBOARD_UID="zHSo4WLgHDpS" | |
| "$SED_CMD" "${SED_INPLACE_ARGS[@]}" "s/YiGL8hBZ0aac/$SHARED_DASHBOARD_UID/" "$NEXT_GEN_SHARED_FILE" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@tenfyzhong: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #4775
What is changed and how it works?
scripts/generate-next-gen-metrics.shso it rewrites the shared-scope next-gen dashboard UID during generationmetrics/nextgengrafana/ticdc_new_arch_next_gen.jsonwith the refreshed shared dashboard UIDgenerate-next-gen-grafanaoutput reproducible undermake checkCheck List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit