Skip to content

import: write RPC will check region epoch before continue && br: pre-check TiKV disk space before download (#17238) (#17569) #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2025

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Dec 5, 2024

close tikv#17224 and close tikv#15053

pick these two commit

Add a disk usage check when execute download and apply RPC from br. When the disk is not Normal, the request would be rejected.

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


@ti-chi-bot ti-chi-bot bot added the size/L label Dec 5, 2024
@CalvinNeo
Copy link
Member Author

image
image

lance6716 and others added 2 commits May 21, 2025 18:11
close tikv#17224

Add a disk usage check when execute `download` and `apply` RPC from br.
When the disk is not `Normal`, the request would be rejected.

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: ris <[email protected]>
Co-authored-by: hillium <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Copy link
Collaborator

/test pull-unit-test

1 similar comment
@JaySon-Huang
Copy link
Collaborator

/test pull-unit-test

@JaySon-Huang JaySon-Huang changed the title br: pre-check TiKV disk space before download (#17238) (#17569) import: write RPC will check region epoch before continue && br: pre-check TiKV disk space before download (#17238) (#17569) May 23, 2025
CalvinNeo added 2 commits May 23, 2025 16:50
Signed-off-by: Calvin Neo <[email protected]>
f
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member Author

/retest

a
Signed-off-by: Calvin Neo <[email protected]>
Copy link

ti-chi-bot bot commented May 23, 2025

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented May 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaySon-Huang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang JaySon-Huang merged commit 47ebe57 into pingcap:raftstore-proxy-7.5 May 23, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants