Chery-pick tikv#17950 and tikv#19071 to raftstore-proxy-8.5 #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengliqi <[email protected]>
gengliqi
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
close tikv#17018 Remove the logic that tries to adjust replica reads' read index in `advance_replica_reads`. This optimization is no correct anymore after 1pc/async-commit is introduced because an earlier readIndex request can rely on a higher committed index due to async-commit lock, thus decrease the read index can cause follower read request reading out-dated data. Signed-off-by: glorv <[email protected]>
gengliqi
changed the title
ti-chi-bot
bot
merged commit e521fda
into
pingcap:raftstore-proxy-8.5
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note