Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: update TiDB and parser #607

Merged
merged 2 commits into from
Mar 21, 2022
Merged

dep: update TiDB and parser #607

merged 2 commits into from
Mar 21, 2022

Conversation

lance6716
Copy link
Collaborator

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: ref #596

What is changed and how it works?

update parser to include pingcap/tidb#33212

Check List

Tests

Code changes

Side effects

Related changes

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lance6716
Copy link
Collaborator Author

/hold

@lance6716
Copy link
Collaborator Author

/unhold

local test passed

@lance6716
Copy link
Collaborator Author

/run-unit-tests

amyangfei
amyangfei reviewed Mar 21, 2022
View reviewed changes
go.mod1 Outdated
Comment on lines 35 to 36
// FIXME: Change to master TiDB after upgrade TiDB.
replace github.com/pingcap/tidb => github.com/oh-my-tidb/tidb v1.1.0-beta.0.20220218042203-2e273f3f990d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this replace expected?

@lance6716
address comment
ebd8701 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Mar 21, 2022
@purelind
Copy link

/run-unit-tests

@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebd8701

@ti-chi-bot ti-chi-bot merged commit 4dd10bc into pingcap:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
size/L status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @purelind @amyangfei