executor: add slow-log file meta cache to avoid repeat read file meta information#21536
Closed
crazycs520 wants to merge 11 commits intopingcap:masterfrom
Closed
executor: add slow-log file meta cache to avoid repeat read file meta information#21536crazycs520 wants to merge 11 commits intopingcap:masterfrom
crazycs520 wants to merge 11 commits intopingcap:masterfrom
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
crazycs520
added
type/enhancement
github-actions
bot
added
sig/sql-infra
Signed-off-by: crazycs520 <crazycs520@gmail.com>
5 tasks
ti-chi-bot
added
the
needs-rebase
Member
|
@crazycs520: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When there are many
tidb-slow.logfiles, functiongetAllFileswill spend much time to read the start time and end time of the slow-log file. This PR adds a file meta cache to avoid resolve log file time.Related PR: pingcap/sysutil#26
Here is a tiny benchmark when there are 1247
tidb_slow_query.logfiles.Before this PR,
getAllFilesfunction cost16.3s.This PR, after the first run time then the file meta was cached, then
getAllFilesfunction only cost23ms.Related changes
Check List
Tests
Side effects
Release note