Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update version in version_comment #43425

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 26, 2023

What problem does this PR solve?

Issue Number: ref #7968

Problem Summary:

What is changed and how it works?

In #42560 the mysql component of the version that TiDB reports was updated. However the version that is in the version_comment wasn't updated.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

No release note as the release note for #42560 covers this already.

With this PR:

$ mysql -u root -P 4000 -h 127.0.0.1
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 403
Server version: 8.0.11-TiDB-v7.2.0-alpha-42-g7c5e7ea851-dirty TiDB Server (Apache License 2.0) Community Edition, MySQL 8.0 compatible

Copyright (c) 2000, 2023, Oracle and/or its affiliates.

Oracle is a registered trademark of Oracle Corporation and/or its
affiliates. Other names may be trademarks of their respective
owners.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

mysql> show variables like 'version_comment';
+-----------------+--------------------------------------------------------------------------+
| Variable_name   | Value                                                                    |
+-----------------+--------------------------------------------------------------------------+
| version_comment | TiDB Server (Apache License 2.0) Community Edition, MySQL 8.0 compatible |
+-----------------+--------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> QUIT
Bye

@dveeden dveeden requested a review from a team as a code owner April 26, 2023 06:22
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2023
@hawkingrei hawkingrei requested a review from bb7133 April 26, 2023 06:31
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2023
@mjonss
Copy link
Contributor

mjonss commented Apr 26, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6e975f2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2023
@hawkingrei
Copy link
Member

@bb7133 it needs the configuration reviewer's approval.

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Apr 26, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit da4bc2b into pingcap:master Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants