Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: set proper default flen of decimal(0) columns (#54028) #55695

Merged
merged 2 commits into from
Sep 3, 2024
Merged

ddl: set proper default flen of decimal(0) columns (#54028) #55695

merged 2 commits into from
Sep 3, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54028

What problem does this PR solve?

Issue Number: close #53779

Problem Summary:

See #53779.

What changed and how does it work?

Handle Decimal(0) properly in preprocessing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 27, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 27, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. labels Aug 27, 2024
@ti-chi-bot ti-chi-bot closed this Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 2, 2024
@tangenta tangenta reopened this Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2024
Benjamin2037
Benjamin2037 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 08:09:03.091636967 +0000 UTC m=+259067.609689885: ☑️ agreed by tangenta.
  • 2024-09-02 08:31:27.724525806 +0000 UTC m=+260412.242578732: ☑️ agreed by Benjamin2037.

@tangenta
Copy link
Contributor

tangenta commented Sep 2, 2024

/retest

@tangenta
Copy link
Contributor

tangenta commented Sep 3, 2024

/retest

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@5cbe32a). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #55695   +/-   ##
================================================
  Coverage               ?   73.7999%           
================================================
  Files                  ?       1097           
  Lines                  ?     353396           
  Branches               ?          0           
================================================
  Hits                   ?     260806           
  Misses                 ?      75964           
  Partials               ?      16626

@ti-chi-bot ti-chi-bot bot merged commit 6338796 into pingcap:release-6.5 Sep 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

@tangenta tangenta

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @tangenta @Benjamin2037