Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support the vector index #56403

Closed
wants to merge 8 commits into from

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 29, 2024

What problem does this PR solve?

Issue Number: close #55693

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support the vector index

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner and removed do-not-merge/needs-tests-checked labels Sep 29, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037, benmeadowcroft, bornchanger, gmhdbjd, qw4990, windtalker for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented Sep 29, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 29, 2024
@zimulala zimulala removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 29, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

@zimulala: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lightning-integration-test 06b355b link true /test pull-lightning-integration-test
idc-jenkins-ci-tidb/build 06b355b link true /test build
pull-integration-ddl-test 06b355b link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/check_dev_2 06b355b link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 06b355b link true /test check-dev
idc-jenkins-ci-tidb/unit-test 06b355b link true /test unit-test
pull-br-integration-test 06b355b link true /test pull-br-integration-test
idc-jenkins-ci-tidb/mysql-test 06b355b link true /test mysql-test
pull-mysql-client-test 06b355b link true /test pull-mysql-client-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zimulala zimulala closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the Vector Index
2 participants