ddl: abstract decode job args v1 #56420

D3Hunter · 2024-09-30T07:18:02Z

What problem does this PR solve?

Issue Number: ref #53930

Problem Summary:

What changed and how does it work?

add decodeV1 to JobArgs, adjust other fillJobV1 to return args directly

Check List

Tests

Unit test, existing tests should cover it
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2024-09-30T07:18:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from d3hunter, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/ddl/OWNERS
pkg/meta/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiprow · 2024-09-30T07:18:21Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-09-30T07:43:12Z

Codecov Report

Attention: Patch coverage is 92.55952% with 25 lines in your changes missing coverage. Please review.

Project coverage is 76.0402%. Comparing base (74034d4) to head (78e7b68).

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56420        +/-   ##
================================================
+ Coverage   73.3632%   76.0402%   +2.6769%     
================================================
  Files          1624       1646        +22     
  Lines        448069     455847      +7778     
================================================
+ Hits         328718     346627     +17909     
+ Misses        99210      87614     -11596     
- Partials      20141      21606      +1465

Flag	Coverage Δ
integration	`51.8223% <25.5952%> (?)`
unit	`72.4573% <92.5595%> (-0.0063%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.0167% <ø> (+17.5037%)`	⬆️

D3Hunter · 2024-09-30T08:47:30Z

/test fast_test_tiprow_ddlargsv1
/test pull-unit-test-ddlv1

tiprow · 2024-09-30T08:47:51Z

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test fast_test_tiprow_ddlargsv1
/test pull-unit-test-ddlv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-30T08:48:06Z

/test fast_test_tiprow_ddlargsv1

ti-chi-bot · 2024-09-30T08:48:09Z

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test pull-unit-test-ddlv1

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow_ddlargsv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-09-30T09:20:03Z

/retest

D3Hunter · 2024-09-30T09:24:07Z

/test pull-unit-test-ddlv1

D3Hunter · 2024-09-30T09:24:23Z

v1 pass https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_unit_test_ddlv1/detail/pull_unit_test_ddlv1/5/pipeline

tiprow · 2024-09-30T09:24:29Z

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test pull-unit-test-ddlv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-30T09:40:22Z

/retest

D3Hunter · 2024-09-30T12:32:41Z

/test fast_test_tiprow_ddlargsv1
/test pull-unit-test-ddlv1

tiprow · 2024-09-30T12:33:02Z

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test fast_test_tiprow_ddlargsv1
/test pull-unit-test-ddlv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-30T12:33:17Z

/test fast_test_tiprow_ddlargsv1

ti-chi-bot · 2024-09-30T12:33:21Z

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test pull-unit-test-ddlv1

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow_ddlargsv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-09-30T19:23:49Z

/retest

D3Hunter added 4 commits September 30, 2024 13:04

change

0d6acc8

change

d941c9e

change

e0231b0

Merge remote-tracking branch 'upstream/master' into cache-argsv1

d9dc0e0

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 30, 2024

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 30, 2024

change

f79318b

lint

d5ffe02

D3Hunter added the ok-to-test Indicates a PR is ready to be tested. label Sep 30, 2024

D3Hunter requested review from lance6716 and joccau September 30, 2024 08:43

Merge remote-tracking branch 'upstream/master' into abstract-decodev1

16cffe3

Merge remote-tracking branch 'upstream/master' into abstract-decodev1

78e7b68

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: abstract decode job args v1 #56420

ddl: abstract decode job args v1 #56420

D3Hunter commented Sep 30, 2024

ti-chi-bot bot commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

codecov bot commented Sep 30, 2024 •

edited

Loading

D3Hunter commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

ti-chi-bot bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

ti-chi-bot bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

ddl: abstract decode job args v1 #56420

Are you sure you want to change the base?

ddl: abstract decode job args v1 #56420

Conversation

D3Hunter commented Sep 30, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

codecov bot commented Sep 30, 2024 • edited Loading

Codecov Report

D3Hunter commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

ti-chi-bot bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

ti-chi-bot bot commented Sep 30, 2024

D3Hunter commented Sep 30, 2024

codecov bot commented Sep 30, 2024 •

edited

Loading