Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: Cherry pick 58981 to release 8.5 #59638

Open
wants to merge 3 commits into
base: release-8.5
Choose a base branch
from

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: #58685

Problem Summary:
This hotfix includes patches needed by the compatibility between log backup and restore snapshot.

What changed and how does it work?

The following PRs are picked:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 19, 2025
Copy link

ti-chi-bot bot commented Feb 19, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 19, 2025
Copy link

tiprow bot commented Feb 19, 2025

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 42.89229% with 2089 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@84f6a9a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #59638   +/-   ##
================================================
  Coverage               ?   38.4006%           
================================================
  Files                  ?       1694           
  Lines                  ?     616578           
  Branches               ?          0           
================================================
  Hits                   ?     236770           
  Misses                 ?     356034           
  Partials               ?      23774           
Flag Coverage Δ
integration 38.4006% <42.8922%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 47.3488% <0.0000%> (?)

@YuJuncen
Copy link
Contributor Author

/test unit-test

not my fault...

Copy link

ti-chi-bot bot commented Feb 20, 2025

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-unit-test-ddlv1
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test-centos
/test pull-check2-centos
/test pull-common-test
/test pull-common-test-centos
/test pull-e2e-test
/test pull-e2e-test-centos
/test pull-integration-common-test
/test pull-integration-common-test-centos
/test pull-integration-copr-test
/test pull-integration-copr-test-centos
/test pull-integration-ddl-test
/test pull-integration-ddl-test-centos
/test pull-integration-e2e-test
/test pull-integration-e2e-test-centos
/test pull-integration-jdbc-test
/test pull-integration-jdbc-test-centos
/test pull-integration-mysql-test
/test pull-integration-mysql-test-centos
/test pull-integration-nodejs-test
/test pull-integration-nodejs-test-centos
/test pull-integration-python-orm-test
/test pull-integration-python-orm-test-centos
/test pull-integration-tidb-tools-test
/test pull-integration-tidb-tools-test-centos
/test pull-lightning-integration-test
/test pull-lightning-integration-test-centos
/test pull-mysql-client-test
/test pull-mysql-client-test-centos
/test pull-mysql-test-centos
/test pull-sqllogic-test
/test pull-sqllogic-test-centos
/test pull-tiflash-test
/test pull-tiflash-test-centos

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_br_integration_test
pingcap/tidb/release-8.5/pull_build
pingcap/tidb/release-8.5/pull_check
pingcap/tidb/release-8.5/pull_check2
pingcap/tidb/release-8.5/pull_mysql_test
pingcap/tidb/release-8.5/pull_unit_test

In response to this:

/test unit-test

not my fault...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Feb 20, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

not my fault...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Feb 20, 2025

@ti-chi-bot[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-unit-test-ddlv1
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test-centos
/test pull-check2-centos
/test pull-common-test
/test pull-common-test-centos
/test pull-e2e-test
/test pull-e2e-test-centos
/test pull-integration-common-test
/test pull-integration-common-test-centos
/test pull-integration-copr-test
/test pull-integration-copr-test-centos
/test pull-integration-ddl-test
/test pull-integration-ddl-test-centos
/test pull-integration-e2e-test
/test pull-integration-e2e-test-centos
/test pull-integration-jdbc-test
/test pull-integration-jdbc-test-centos
/test pull-integration-mysql-test
/test pull-integration-mysql-test-centos
/test pull-integration-nodejs-test
/test pull-integration-nodejs-test-centos
/test pull-integration-python-orm-test
/test pull-integration-python-orm-test-centos
/test pull-integration-tidb-tools-test
/test pull-integration-tidb-tools-test-centos
/test pull-lightning-integration-test
/test pull-lightning-integration-test-centos
/test pull-mysql-client-test
/test pull-mysql-client-test-centos
/test pull-mysql-test-centos
/test pull-sqllogic-test
/test pull-sqllogic-test-centos
/test pull-tiflash-test
/test pull-tiflash-test-centos

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_br_integration_test
pingcap/tidb/release-8.5/pull_build
pingcap/tidb/release-8.5/pull_check
pingcap/tidb/release-8.5/pull_check2
pingcap/tidb/release-8.5/pull_mysql_test
pingcap/tidb/release-8.5/pull_unit_test

In response to this:

/test unit-test

not my fault...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BornChanger
Copy link
Contributor

/retest

Copy link

tiprow bot commented Feb 20, 2025

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BornChanger
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2025
Copy link

ti-chi-bot bot commented Feb 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-20 21:05:58.084296857 +0000 UTC m=+1168200.480518919: ☑️ agreed by BornChanger.

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Feb 21, 2025

/test unit-test

That can't...

Copy link

tiprow bot commented Feb 21, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 21, 2025

@YuJuncen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test ae0304d link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BornChanger
Copy link
Contributor

/rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants