Skip to content

global-sort: accelerate adding unique index using global sort #61010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release-8.5
Choose a base branch
from

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented May 8, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

This pr pick #60848 and #61094 manually

What changed and how does it work?

When adding unique indexes using global sort:

  1. Skip checkDuplicateForUniqueIndex
  2. Use common.NoopKeyAdapter instead of common.DupDetectKeyAdapter
  3. Use OnDuplicateKeyError for step read index, merge sort and cloud import
  4. Remove useless keyAdapter in pkg/lightning/backend/external package

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels May 8, 2025
Copy link

ti-chi-bot bot commented May 8, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2025
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 85.44304% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@de28749). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #61010   +/-   ##
================================================
  Coverage               ?   77.2193%           
================================================
  Files                  ?       1643           
  Lines                  ?     450115           
  Branches               ?          0           
================================================
  Hits                   ?     347576           
  Misses                 ?      81236           
  Partials               ?      21303           
Flag Coverage Δ
integration 50.4008% <82.2784%> (?)
unit 72.6835% <49.3670%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.0869% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CbcWestwolf
Copy link
Member Author

/retest

1 similar comment
@CbcWestwolf
Copy link
Member Author

/retest

@CbcWestwolf CbcWestwolf force-pushed the ukey-dup-detect-release-8.5 branch from e5a1389 to ce55611 Compare May 28, 2025 06:46
@CbcWestwolf
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2025
Copy link

ti-chi-bot bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 29, 2025
@CbcWestwolf CbcWestwolf force-pushed the ukey-dup-detect-release-8.5 branch 2 times, most recently from 900a9a7 to b13b5b6 Compare May 29, 2025 14:24
@CbcWestwolf
Copy link
Member Author

/retest

@CbcWestwolf CbcWestwolf force-pushed the ukey-dup-detect-release-8.5 branch from b13b5b6 to e80eeb9 Compare May 30, 2025 03:43
@CbcWestwolf CbcWestwolf force-pushed the ukey-dup-detect-release-8.5 branch from e80eeb9 to 73582ab Compare May 30, 2025 03:51
@CbcWestwolf
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant