-
Notifications
You must be signed in to change notification settings - Fork 6k
global-sort: accelerate adding unique index using global sort #61010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
global-sort: accelerate adding unique index using global sort #61010
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #61010 +/- ##
================================================
Coverage ? 77.2193%
================================================
Files ? 1643
Lines ? 450115
Branches ? 0
================================================
Hits ? 347576
Misses ? 81236
Partials ? 21303
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
1 similar comment
/retest |
e5a1389
to
ce55611
Compare
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
900a9a7
to
b13b5b6
Compare
/retest |
b13b5b6
to
e80eeb9
Compare
e80eeb9
to
73582ab
Compare
/retest |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
This pr pick #60848 and #61094 manually
What changed and how does it work?
When adding unique indexes using global sort:
checkDuplicateForUniqueIndex
common.NoopKeyAdapter
instead ofcommon.DupDetectKeyAdapter
OnDuplicateKeyError
for stepread index
,merge sort
andcloud import
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.