ImportInto: add import sdk for cloud | tidb-test=b256656b231ebd8f752e8738e89fc64f5263721a #61016

GMHDBJD · 2025-05-08T06:40:58Z

What problem does this PR solve?

Issue Number: ref #61264

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-05-08T06:41:15Z

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-05-20T13:47:09Z

Codecov Report

Attention: Patch coverage is 86.72566% with 45 lines in your changes missing coverage. Please review.

Project coverage is 73.5527%. Comparing base (d08abd5) to head (ad55b47).
Report is 8 commits behind head on feature/next-gen-importer.

Additional details and impacted files

@@                        Coverage Diff                        @@
##           feature/next-gen-importer     #61016        +/-   ##
=================================================================
+ Coverage                    73.1819%   73.5527%   +0.3708%     
=================================================================
  Files                           1724       1727         +3     
  Lines                         477752     484073      +6321     
=================================================================
+ Hits                          349628     356049      +6421     
+ Misses                        106707     106471       -236     
- Partials                       21417      21553       +136

Flag	Coverage Δ
integration	`42.4891% <0.0000%> (?)`
unit	`72.3794% <86.7256%> (+0.0040%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7804% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.0863% <ø> (-1.6467%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joechenrh

These comments don't need to be resolved for now, we can change it in PR for master.

joechenrh · 2025-05-21T06:33:50Z

pkg/executor/importer/cloud_sdk.go

+}
+
+// GetTablesMeta implements the CloudImportSDK interface
+func (sdk *ImportSDK) GetTablesMeta(ctx context.Context) ([]*TableMeta, error) {


Seems like we can store allDataFiles in ImportSDK and initialize it in NewImportSDK

actually I think cloud only need GetTablesMeta, no need to call GetableMetaByName, so the allDataFiles will only calculate once

joechenrh · 2025-05-21T06:42:08Z

pkg/executor/importer/cloud_sdk.go

+	}
+
+	// Process data files
+	dataFiles, totalSize, err := sdk.processDataFiles(tblMeta.DataFiles)


Make processDataFiles return TableMeta directly?

pkg/executor/importer/cloud_sdk.go

joechenrh · 2025-05-21T07:52:15Z

tests/realtikvtest/importintotest4/cloud_sdk_test.go

+	mock.ExpectQuery(`SELECT SCHEMA_NAME FROM information_schema.SCHEMATA`).
+		WillReturnRows(sqlmock.NewRows([]string{"SCHEMA_NAME"}).AddRow("cloud_csv"))
+	mock.ExpectQuery("SHOW CREATE TABLE `cloud_csv`.`t`").
+		WillReturnRows(sqlmock.NewRows([]string{"Create Table"}).AddRow(`create table t (a bigint primary key, b varchar(100), c varchar(100), d int,
+		key(a), key(c,d), key(d));`))


Why we need this

Verify table exist if there is no table schema in source files

pkg/executor/importer/cloud_sdk.go

GMHDBJD · 2025-05-21T09:04:46Z

/retest

tiprow · 2025-05-21T09:05:27Z

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

GMHDBJD · 2025-05-22T05:50:58Z

/retest

tiprow · 2025-05-22T05:51:20Z

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

GMHDBJD · 2025-05-22T06:53:14Z

/retest

tiprow · 2025-05-22T06:53:37Z

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

GMHDBJD · 2025-05-22T07:11:11Z

/retest

tiprow · 2025-05-22T07:11:33Z

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Benjamin2037

LGTM

ti-chi-bot · 2025-05-23T05:53:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, joechenrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037]
~~pkg/executor/importer/OWNERS~~ [Benjamin2037]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-05-23T05:53:08Z

[LGTM Timeline notifier]

Timeline:

2025-05-21 07:54:25.682185265 +0000 UTC m=+161902.783352487: ☑️ agreed by joechenrh.
2025-05-23 05:53:07.995927556 +0000 UTC m=+12213.941192366: ☑️ agreed by Benjamin2037.

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2025

GMHDBJD added 5 commits May 19, 2025 23:00

stash

be3dba7

import_into: add create schemas sdk for cloud

427444b

stash

851f210

stash

3db502c

add test

7193da4

GMHDBJD force-pushed the createSchemas branch from 37eaeb9 to 7193da4 Compare May 19, 2025 15:00

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2025

GMHDBJD changed the title ~~ImportInto: add create schemas sdk for cloud~~ ImportInto: add import sdk for cloud May 19, 2025

GMHDBJD changed the base branch from master to CloudImportNextGen May 19, 2025 15:01

GMHDBJD changed the title ~~ImportInto: add import sdk for cloud~~ ImportInto: add import sdk for cloud | tidb-test=master May 19, 2025

update

41644c5

GMHDBJD changed the base branch from CloudImportNextGen to feature/next-gen-importer May 20, 2025 13:07

fix bazel

98472f5

joechenrh approved these changes May 21, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 21, 2025

GMHDBJD added 2 commits May 21, 2025 16:03

fix lint

d760f63

address comment

923f550

fix ut

ad55b47

GMHDBJD changed the title ~~ImportInto: add import sdk for cloud | tidb-test=master~~ ImportInto: add import sdk for cloud | tidb-test=b256656b231ebd8f752e8738e89fc64f5263721a May 22, 2025

GMHDBJD removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels May 22, 2025

Benjamin2037 approved these changes May 23, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2025

ti-chi-bot bot added the approved label May 23, 2025

ti-chi-bot bot merged commit 66debdc into pingcap:feature/next-gen-importer May 23, 2025
21 checks passed

ImportInto: add import sdk for cloud | tidb-test=b256656b231ebd8f752e8738e89fc64f5263721a #61016

ImportInto: add import sdk for cloud | tidb-test=b256656b231ebd8f752e8738e89fc64f5263721a #61016

Uh oh!

Conversation

GMHDBJD commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented May 8, 2025

Uh oh!

codecov bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joechenrh left a comment

Choose a reason for hiding this comment

Uh oh!

joechenrh May 21, 2025

Choose a reason for hiding this comment

Uh oh!

GMHDBJD May 21, 2025

Choose a reason for hiding this comment

Uh oh!

joechenrh May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joechenrh May 21, 2025

Choose a reason for hiding this comment

Uh oh!

GMHDBJD May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GMHDBJD commented May 21, 2025

Uh oh!

tiprow bot commented May 21, 2025

Uh oh!

GMHDBJD commented May 22, 2025

Uh oh!

tiprow bot commented May 22, 2025

Uh oh!

GMHDBJD commented May 22, 2025

Uh oh!

tiprow bot commented May 22, 2025

Uh oh!

GMHDBJD commented May 22, 2025

Uh oh!

tiprow bot commented May 22, 2025

Uh oh!

Benjamin2037 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented May 23, 2025

Uh oh!

ti-chi-bot bot commented May 23, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Uh oh!

GMHDBJD commented May 8, 2025 •

edited

Loading

codecov bot commented May 20, 2025 •

edited

Loading