Skip to content

metrics: fix panel "retryable error" #61052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented May 9, 2025

What problem does this PR solve?

Issue Number: close #61051

Problem Summary:
After this PR:
image

What changed and how does it work?

Move the panel to DDL

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels May 9, 2025
Signed-off-by: wjhuang2016 <[email protected]>
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0574%. Comparing base (f4d2318) to head (2b5eb1e).
Report is 25 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61052        +/-   ##
================================================
+ Coverage   73.1387%   74.0574%   +0.9186%     
================================================
  Files          1724       1724                
  Lines        477000     483009      +6009     
================================================
+ Hits         348872     357704      +8832     
+ Misses       106705     104038      -2667     
+ Partials      21423      21267       -156     
Flag Coverage Δ
integration 43.0403% <ø> (?)
unit 72.9126% <ø> (+0.5452%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 48.0647% <ø> (+0.5105%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lance6716
Copy link
Contributor

The unique labels of "retryable error" may grow to a large number. It may cause some performance problems when display them.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
Copy link

ti-chi-bot bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
Copy link

ti-chi-bot bot commented May 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-14 07:38:30.075782467 +0000 UTC m=+517176.223743680: ☑️ agreed by zimulala.
  • 2025-05-14 09:43:50.381844794 +0000 UTC m=+524696.529806013: ☑️ agreed by CbcWestwolf.

@ti-chi-bot ti-chi-bot bot merged commit 3304b3c into pingcap:master May 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grafana metrics "retryable error" is wrong
4 participants